Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"disable AI review" also jumps to the last official move #858

Closed
flovo opened this issue Aug 12, 2019 · 2 comments

Comments

@flovo
Copy link
Contributor

commented Aug 12, 2019

Summary

When the user disables AI review (right panel), the current move changes to the last official move.

Steps To Reproduce:

  1. Go to Game View
  2. Go to any but the last move
  3. Click on "Disable AI review" in the right panel
  4. We are now on the last official move.

Additional Information:

https://forums.online-go.com/t/disable-ai-review-does-not-hide-the-winrate-changes/22510

@flovo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

This is probably caused by

this.goban.setMode("play");

flovo added a commit to flovo/online-go.com that referenced this issue Aug 12, 2019

Don't jump to last move when disable AI reveiw
Don't swicht "Play" mode after the user disabled AI review.

Fix for issue online-go#858

@anoek anoek closed this Aug 13, 2019

@anoek

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.