Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player-container colour tweaks for improved "white" container #1006

Merged
merged 1 commit into from Dec 9, 2019

Conversation

GreenAsJade
Copy link
Contributor

@GreenAsJade GreenAsJade commented Dec 5, 2019

Fixes #1005

Proposed Changes

Make the "white player container" have more whiteness, and be whiter at the bottom where the player name and score is, so it is more obvious which container is for "white"

Current dark game underway
old-dark

New dark game underway
new-dark

Current dark game paused
old-dark-paused

New dark game paused
new-dark-paused

Current light game underway

old-light

New light game underway

new-light

Current light game paused

old-light-paused

New light game paused

new-light-paused

@GreenAsJade
Copy link
Contributor Author

Note: the resume button is purple, which helps justify why there is a purple tinge to the proposed "paused" colours. Some coloured tinge is necessary so that the text can be readable across the range of greys that it sits on.

@anoek
Copy link
Member

anoek commented Dec 9, 2019

Good improvements, thanks!

@anoek anoek merged commit cb0891f into online-go:devel Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Darker background for white player name in review mode
2 participants