Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable score estimator when analysis is disabled #885

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@flovo
Copy link
Contributor

commented Sep 6, 2019

resolves gh-813

The score estimator is an analysis tool so should be disabled when analysis is disabled in the match options.

Disable score estimator when analysis is disabled
resolves gh-813

The score estimator is an analysis tool so should be disabled when analysis is disabled in the match options.
@anoek

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Thanks for the PR!

@anoek anoek merged commit fdcef75 into online-go:devel Sep 6, 2019

1 check passed

Shippable Run 1426 status is SUCCESS.
Details
@raylu

This comment has been minimized.

Copy link

commented Sep 7, 2019

if I'm reading this right, this only affects users logged in as one of the players. logging out (in a separate tab) allows you to use the score estimator?

@alexmitrani

This comment has been minimized.

Copy link

commented Sep 7, 2019

many thanks for implementing this @flovo and @anoek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.