Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: < on indexed column #42

Closed
plentylife opened this issue May 12, 2018 · 7 comments
Closed

Bug: < on indexed column #42

plentylife opened this issue May 12, 2018 · 7 comments
Labels

Comments

@plentylife
Copy link

@plentylife plentylife commented May 12, 2018

This is a kind of funny bug.

I have a column like this
{key: 'lastNotification', type: 'number', props: ['idx']}
and a query like this
nSQL(TABLE).query('select').where(['lastNotification', '<', before]).exec()

The above does not work.
If I remove 'idx' from the column, it works
OR if I switch '<' to '<=' it works

@only-cliches
Copy link
Owner

@only-cliches only-cliches commented May 13, 2018

Thanks for the bug report, I'll have this patched in the next release.

@only-cliches
Copy link
Owner

@only-cliches only-cliches commented May 13, 2018

Alright, just pushed v1.5.5, range queries with secondary indexes have been resolved.

@plentylife
Copy link
Author

@plentylife plentylife commented May 14, 2018

@only-cliches
Copy link
Owner

@only-cliches only-cliches commented May 14, 2018

Awesome to hear, thanks man! Marking this one resolved..

@plentylife
Copy link
Author

@plentylife plentylife commented May 17, 2018

I'm on 1.5.8 now and there's an opposite issue
Querying with '>' on an indexed column does not work :)

@only-cliches
Copy link
Owner

@only-cliches only-cliches commented May 18, 2018

1.5.9 should resolve things, I added tests as well so we don't get feature/bug regression.

@plentylife
Copy link
Author

@plentylife plentylife commented May 18, 2018

Confirmed. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants