Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shape existence check in GatherElements shape inference logic #2402

Merged
merged 5 commits into from Oct 22, 2019

Conversation

@hariharans29
Copy link
Contributor

hariharans29 commented Oct 18, 2019

The shape inference logic basically propagated the shape of the indices input to the output shape. This logic is correct but we need to add a guard to make sure the indices input has a shape associated with it.

@hariharans29 hariharans29 requested review from onnx/sig-archinfra-approvers as code owners Oct 18, 2019
onnx/defs/tensor/defs.cc Outdated Show resolved Hide resolved
@gramalingam gramalingam merged commit 3ea3b0e into onnx:master Oct 22, 2019
6 checks passed
6 checks passed
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: py2-gcc7-ubuntu16.04 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
snnn added a commit to snnn/onnx that referenced this pull request Oct 22, 2019
…nx#2402)

* Add shape existence check guard in GatherElements shape inference logic

* PR comments

* PR comments
ebarsoum added a commit that referenced this pull request Oct 23, 2019
) (#2412)

* Add shape existence check guard in GatherElements shape inference logic

* PR comments

* PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.