Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter check for Shape's input: check input type #3757

Merged
merged 1 commit into from Oct 5, 2021

Conversation

jcwchen
Copy link
Member

@jcwchen jcwchen commented Oct 5, 2021

Description
!hasNInputShapes(ctx, 1) is still needed to check Shape's input. Besides, I removed ctx.getInputType(0)->tensor_type().has_shape() because this check is included in !hasNInputShapes(ctx, 1).

Motivation and Context
onnx/tensorflow-onnx#1731 Shape'15 crashes if the input type is not specified.

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen requested a review from a team as a code owner Oct 5, 2021
@jcwchen jcwchen closed this Oct 5, 2021
@jcwchen jcwchen reopened this Oct 5, 2021
@jcwchen jcwchen changed the title Strict input check for Shape's input Stricter check for Shape's input: check input type Oct 5, 2021
@gramalingam gramalingam merged commit 767f752 into onnx:master Oct 5, 2021
58 checks passed
@jcwchen jcwchen deleted the jcw/fix-shape branch Oct 5, 2021
postrational pushed a commit that referenced this issue Oct 12, 2021
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
mhamilton723 pushed a commit to mhamilton723/onnx that referenced this issue Oct 22, 2021
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Mark <mhamilton723@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants