Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the annotation: fix the label serial number mistake #4426

Merged
merged 2 commits into from Aug 10, 2022
Merged

Modify the annotation: fix the label serial number mistake #4426

merged 2 commits into from Aug 10, 2022

Conversation

tangjicheng46
Copy link
Contributor

Description

  • Describe your changes.

origin annotation in onnx/onnx/common/ir_pb_converter.cc

onnx/onnx/common/ir_pb_converter.cc

Lines 229 to 234 in eb634ad

// 1) add all input (to the graph) Values, owned by the sentinel Param node
// 2) add all Nodes and their output Values, but don't intialize inputs
// 3) initialize inputs of all Nodes
// 4) initialize inputs of the Return sentinel node
// 5) fill in type info for graph outputs, and register them as outputs
// 5) fill in type info for Values from the value_info list in the graph

this pull request replace the second label "5)" with "6)"

Motivation and Context
Fix annotation mistaken

@tangjicheng46 tangjicheng46 requested a review from a team as a code owner August 10, 2022 06:23
daquexian
daquexian approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@daquexian daquexian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@daquexian
Copy link
Member

Please sign the DCO following the instructions in https://github.com/onnx/onnx/pull/4426/checks?check_run_id=7760879314. Thanks!

jcwchen
jcwchen approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to include the fix for this issue: #4425. Thank you for the contribution!

tangjicheng and others added 2 commits August 10, 2022 23:53
@jcwchen jcwchen merged commit baffc92 into onnx:main Aug 10, 2022
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
@tangjicheng46
Modify the annotation: fix the label serial number mistake (onnx#4426)
58e7bc3 
Signed-off-by: tangjicheng <tangjicheng@tencent.com>

Signed-off-by: tangjicheng <tangjicheng@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daquexian daquexian daquexian approved these changes

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tangjicheng46 @daquexian @jcwchen