Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reducesum test name - test name was duplicated #5664

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

liqunfu
Copy link
Collaborator

@liqunfu liqunfu commented Oct 13, 2023

Description

fix test name for reducesum op

Motivation and Context

fix test data

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu requested a review from a team as a code owner October 13, 2023 02:49
@liqunfu liqunfu added this to the 1.15 milestone Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
onnx/backend/test/case/node/reducesum.py 0.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@justinchuby
Copy link
Contributor

Would be helpful to add why this is needed in the PR description. Thanks!

@justinchuby justinchuby changed the title fix reducesum test name Update reducesum test name Oct 13, 2023
@liqunfu
Copy link
Collaborator Author

liqunfu commented Oct 13, 2023

Would be helpful to add why this is needed in the PR description. Thanks!

"test_reduce_sum_empty_set" is used twice. the first test is override by the second test.

@liqunfu liqunfu changed the title Update reducesum test name Update reducesum test name - test name was duplicated Oct 13, 2023
@justinchuby justinchuby added the review needed: operators approvers Require reviews from members of operators-approvers label Oct 13, 2023
@xadupre xadupre added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit a93ec80 Oct 16, 2023
36 checks passed
@xadupre xadupre deleted the liqun/reduce_sum_empty_set_non_reduced_axis_zero branch October 16, 2023 10:42
liqunfu added a commit that referenced this pull request Oct 17, 2023
### Description
fix test name for reducesum op

### Motivation and Context
fix test data

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review needed: operators approvers Require reviews from members of operators-approvers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants