Skip to content

Remove unnecessary secrets in pipeline#6661

Merged
andife merged 2 commits into
mainfrom
remove_unused_variable
Jan 27, 2025
Merged

Remove unnecessary secrets in pipeline#6661
andife merged 2 commits into
mainfrom
remove_unused_variable

Conversation

@andife

@andife andife commented Jan 26, 2025

Copy link
Copy Markdown
Member

Description

  • Remove the secrets that are no longer required in the reusable workflow (no more direct publishing there)
  • Add toplevel permissions: Is "read" correct here?
  • Hints found by: https://github.com/woodruffw/zizmor

Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife requested a review from a team as a code owner January 26, 2025 21:14
@andife andife added the run release CIs Use this label to trigger release tests in CI label Jan 26, 2025
@codecov

codecov Bot commented Jan 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.49%. Comparing base (0a0aa1d) to head (444dcc8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6661   +/-   ##
=======================================
  Coverage   57.49%   57.49%           
=======================================
  Files         507      507           
  Lines       31632    31632           
  Branches     3048     3048           
=======================================
  Hits        18187    18187           
  Misses      12618    12618           
  Partials      827      827           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread .github/workflows/create_release.yml Outdated

@justinchuby justinchuby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Jan 27, 2025
@andife andife temporarily deployed to testpypi-weekly January 27, 2025 05:46 — with GitHub Actions Inactive
@andife andife added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit c143714 Jan 27, 2025
@andife andife deleted the remove_unused_variable branch January 27, 2025 11:50
seungwoo-ji-03 pushed a commit to seungwoo-ji-03/onnx that referenced this pull request Feb 17, 2025
### Description

- Remove the secrets that are no longer required in the reusable
workflow (no more direct publishing there)
- Add toplevel permissions: Is "read" correct here?
- Hints found by: https://github.com/woodruffw/zizmor

---------

Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: seungwoo-ji <seungwoo.ji@nuvilab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run release CIs Use this label to trigger release tests in CI

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants