Remove unnecessary secrets in pipeline#6661
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6661 +/- ##
=======================================
Coverage 57.49% 57.49%
=======================================
Files 507 507
Lines 31632 31632
Branches 3048 3048
=======================================
Hits 18187 18187
Misses 12618 12618
Partials 827 827 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Jan 27, 2025
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
seungwoo-ji-03
pushed a commit
to seungwoo-ji-03/onnx
that referenced
this pull request
Feb 17, 2025
### Description - Remove the secrets that are no longer required in the reusable workflow (no more direct publishing there) - Add toplevel permissions: Is "read" correct here? - Hints found by: https://github.com/woodruffw/zizmor --------- Signed-off-by: Andreas Fehlner <fehlner@arcor.de> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: seungwoo-ji <seungwoo.ji@nuvilab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description