Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: switch to minitest 5 #32

Merged
merged 3 commits into from May 28, 2014
Merged

tests: switch to minitest 5 #32

merged 3 commits into from May 28, 2014

Conversation

ktdreyer
Copy link
Contributor

The first commit in this pull request switches resque-cleaner's test suite to Minitest. (Ruby 1.9+ uses Minitest as the backend for Test::Unit. As of Minitest 5, the shim has broken some compatibility with Test::Unit::TestCase in some scenarios.)

The second commit in this pull request removes the dependency on resque/server/test_helper. The Resque developers have removed resque/server/test_helper.rb in Resque's master branch when they split out resque-web (resque/resque@b2ca4ce). It seems that this test_helper is an internal implementation detail and that external consumers should not rely on it. Additionally, in Resque v1.25.2, resque/server/test_helper.rb adjusts the Test::Unit::TestCase class. Now that resque-cleaner uses Minitest, we want to adjust the Minitest::Spec class instead.

The third commit in this pull request synchronizes the "kill test server" with the implementation in Resque. This allows Travis CI to properly kill the test server so that the tests pass there.

Ruby 1.9+ uses Minitest as the backend for Test::Unit. As of Minitest 5,
the shim has broken some compatibility with Test::Unit::TestCase in some
scenarios.

Adjusts the test suite to support Minitest 5's syntax.
The Resque developers have removed resque/server/test_helper.rb in
Resque's master branch when they split out resque-web (resque commit
b2ca4ceb9457242fc0170d95b3bce9d427baa387).

It seems that this test_helper is an internal implementation detail and
that external consumers should not rely on it.

Additionally, in Resque v1.25.2, resque/server/test_helper.rb adjusts
the Test::Unit::TestCase class. Now that resque-cleaner uses Minitest,
we want to adjust the Minitest::Spec class instead.
Copy the logic from Resque's test/legacy/test_helper.rb.This allows
Travis CI to properly kill the test redis server.
@ono
Copy link
Owner

ono commented May 28, 2014

Awww, nice! Although I plan to rewrite whole tests(see #31), you've made reasonable points and it will help maintaining this repo until the overhaul happens. Thanks a lot!

ono added a commit that referenced this pull request May 28, 2014
tests: switch to minitest 5
@ono ono merged commit bd30229 into ono:master May 28, 2014
@ktdreyer
Copy link
Contributor Author

Cool, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants