Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit in this pull request switches resque-cleaner's test suite to Minitest. (Ruby 1.9+ uses Minitest as the backend for Test::Unit. As of Minitest 5, the shim has broken some compatibility with Test::Unit::TestCase in some scenarios.)
The second commit in this pull request removes the dependency on resque/server/test_helper. The Resque developers have removed
resque/server/test_helper.rb
in Resque's master branch when they split out resque-web (resque/resque@b2ca4ce). It seems that this test_helper is an internal implementation detail and that external consumers should not rely on it. Additionally, in Resque v1.25.2,resque/server/test_helper.rb
adjusts the Test::Unit::TestCase class. Now that resque-cleaner uses Minitest, we want to adjust the Minitest::Spec class instead.The third commit in this pull request synchronizes the "kill test server" with the implementation in Resque. This allows Travis CI to properly kill the test server so that the tests pass there.