New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box showing in very ugly dark colors at any theme #6

Closed
onozaty opened this Issue Nov 4, 2018 · 13 comments

Comments

Projects
None yet
2 participants
@onozaty
Owner

onozaty commented Nov 4, 2018

It is necessary to be able to display beautifully in each theme.

@onozaty

This comment has been minimized.

Owner

onozaty commented Nov 4, 2018

I want actual screen capture.

@theLittlePrinceAD

This comment has been minimized.

theLittlePrinceAD commented Nov 4, 2018

Thank you for your response. Please find attached the screenshots - as with the original Dark and Light FF Quantum themes.

dark theme
light theme

@onozaty

This comment has been minimized.

Owner

onozaty commented Nov 4, 2018

Hi @theLittlePrinceAD

Thank you for screen capture.
I understood the content of the problem, so I will fix it.

@onozaty

This comment has been minimized.

Owner

onozaty commented Nov 13, 2018

Hi @theLittlePrinceAD

It did not reproduce.

image

image

Do you have any other information?

@theLittlePrinceAD

This comment has been minimized.

theLittlePrinceAD commented Nov 13, 2018

I would be happy to provide any info you may need in order to solve the problem.

@onozaty

This comment has been minimized.

Owner

onozaty commented Nov 14, 2018

I'm sorry, but could you provide the following information?

  • Firefox version
  • OS type

Also, because there is a possibility that it may be influenced by other extended functions, can you check other than ShortcutKey2URL by invalidating it?

Thanks

@theLittlePrinceAD

This comment has been minimized.

theLittlePrinceAD commented Nov 19, 2018

I am sorry for being late with my answer, had a business trip.

After disabling ALL add-ons except ShortcutKEY2URL the colors in its window remain the same as reported.
FF - 63.03.
OS - Win 10 Enterprise, 1803 build 17134.407.

@onozaty

This comment has been minimized.

Owner

onozaty commented Nov 19, 2018

Thank you for the information.

Since I tried to fix it, would you please try unpacking the following files as a test and loading from the add-on debug?

Please disable installed Shortcutkey2URL once and install it with reference to the following procedure.

@theLittlePrinceAD

This comment has been minimized.

theLittlePrinceAD commented Nov 19, 2018

  1. Downloaded your ZIP and unpacked.
  2. Disabled the add-on ShortcutKEY2URL (all others are enabled)
  3. "about:debugging" - "Load Temporary Add-on" - open the extension's directory and select actions.js.
  4. add-on active. Working as expected (black text on white background).
@onozaty

This comment has been minimized.

Owner

onozaty commented Nov 20, 2018

Thank you for confirmation.
I am thinking to release it with this, please wait a little more.

@theLittlePrinceAD

This comment has been minimized.

theLittlePrinceAD commented Nov 20, 2018

I am glad things are positive!
Wish you success!
P.S. After your update will edit my comment in FF's add-on site.

onozaty added a commit that referenced this issue Nov 24, 2018

Merge pull request #7 from onozaty/hotfix/6-fixed_background_color_of…
…_popup

#6 ポップアップの背景色が白以外となる問題対処
@onozaty

This comment has been minimized.

Owner

onozaty commented Nov 24, 2018

Hi @theLittlePrinceAD

It was released as 4.0.2.
Please try it.

Thank you for cooperation!

@theLittlePrinceAD

This comment has been minimized.

theLittlePrinceAD commented Nov 24, 2018

Hi,
Everything working as expected!
Thank you for quick and professional support!
Review updated :)
Best regards.

@onozaty onozaty closed this Nov 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment