Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Html" customize type #38

Merged
merged 3 commits into from Mar 16, 2019

Conversation

Projects
None yet
2 participants
@cat-in-136
Copy link
Contributor

commented Mar 9, 2019

This PR introduce a new "HTML" customize type to get more easy-to-use.

For example, when you get a "view customize" that only needs to load simple external JavaScript / CSS resources, you need to write code as follows:

$(document.createElement("script")).attr({
  type: "application/javascript",
  src: "https://some.cdn.example.com/path/to/javascript.js",
  defer: "defer",
  async: "async"
}).appendTo("head");

With a new HTML customization type, you just need to write as follows:

<script type="application/javascript" src="https://some.cdn.example.com/path/to/javascript.js" defer async></script>

Thank you for your great works of redmine-view-customize!

cat-in-136 added some commits Feb 19, 2019

Fix regression bug where language arugument should be a Symbol (to ke…
…ep compatible with redmine 3.x Coderay)

@onozaty onozaty self-assigned this Mar 10, 2019

@onozaty

This comment has been minimized.

Copy link
Owner

commented Mar 10, 2019

Thank you for nice pull request!
After confirmation, I am planning to merge.

Thanks.

@onozaty onozaty changed the base branch from master to develop-2.1.0 Mar 16, 2019

@onozaty onozaty merged commit 933bb2e into onozaty:develop-2.1.0 Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.