Terminal color is not reset when a test fails with some signal

[obfuscated]

This simple test code:

TEST_CASE("failure") { int *a=nullptr; *a=5; }

can be used to reproduce the problem.

I'm testing on OS X at the moment. Don't know if this reproduces on Linux/Windows...

[onqtam]

Couldn't reproduce on Windows, but I checked the logic aaand:

• if there is a signal and it is caught - the printSummary() function is called and it resets the terminal color at its end properly.
• if the signal is not caught then the framework cannot do anything anyway

Do you get the SIGSEGV - Segmentation violation signal string printed?

[obfuscated]

Yes, I get a signal. What do you mean by not caught? You can always install signal handlers for SIGSEGV and do the correct thing when detected. The only signal that cannot be caught by an application is SIGKILL.

Windows has fake signals, so it is not a good idea to test there for this. Test on linux.

[onqtam]

By "not caught" I mean environments such as virtual machines with some linux where I've been unable to catch signals from crashes. But I'll reopen this issue to test it at some point in time.

[patryk-oleniuk]

I was able to reproduce this issue on Linux (Ubuntu 14.04)

[piluke]

This is also happening for me when I kill it with Ctrl-C. I'm using doctest version 2.0.1.

[DenisYaroshevskiy]

Hi

Just wanted to +1. Mac.

[onqtam]

@DenisYaroshevskiy I just pushed a change - let me know if it works for you!

[DenisYaroshevskiy]

@onqtam - didn't help.
Did you update the single header?

[onqtam]

@DenisYaroshevskiy I did - but in the dev branch - it's not yet in master (should have clarified that). I also managed to reproduce the issue on my local linux and this commit managed to fix it: 2d36c23

Can you confirm that you indeed tried the dev branch? If so, I'll think about it more perhaps tomorrow.

[DenisYaroshevskiy]

@onqtam - I used the link from the docs, so I doubt it. Can you give me a link to a new file?

[onqtam]

@DenisYaroshevskiy https://github.com/onqtam/doctest/blob/dev/doctest/doctest.h (the dev part from the URL is the branch - can be substituted for master or a specific version tag like 2.2.0)

[DenisYaroshevskiy]

@onqtam - yes, now it fixed, thanks.

Thanks for letting me know about your test library - I'd use it from now on for my projects since it compiles so fast even with main in regular tests!