Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang unwanted warning in user code #156

Closed
ASMfreaK opened this issue Sep 21, 2018 · 3 comments
Closed

clang unwanted warning in user code #156

ASMfreaK opened this issue Sep 21, 2018 · 3 comments

Comments

@ASMfreaK
Copy link

See actual message in martinmoene/lest#27
Doctest has similar issue with every
CHECK macro.

@onqtam
Copy link
Member

onqtam commented Nov 3, 2018

I'll check it out in a few weeks and try to fix it - sorry for the delay

@onqtam
Copy link
Member

onqtam commented Nov 29, 2018

strange - can you give an exact case that reproduces it - code, doctest version and compiler version?

I also see that for quite some time the -Woverloaded-shift-op-parentheses warning has been suppressed for clang - see here:

https://github.com/onqtam/doctest/blob/f4e82db55c6ab572be6a69bc9d2bc2e726aa9488/doctest/doctest.h#L2018

currently all the examples are compiled with 3.5, 3.6, 3.7, 3.8, 3.9, 4, 5, 6 with all warnings enabled with -Weverything and warnings are treated as errors on the CI.

@onqtam
Copy link
Member

onqtam commented Nov 30, 2018

I'm going to close this for now - feel free to reopen it if the issue is indeed present somehow with the latest version of the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants