Support for bootstrap commands to use custom data for templates #1110
Conversation
Dannyb48
commented
Dec 31, 2022
Dannyb48
commented
- Includes updates to docs
- Includes associated integration tests
- Resolves Support for passing in custom template data when using a template file for the bootstrap and generate commands #1100
|
@onsi when you get a chance can you review this PR? |
|
hey @Dannyb48 this looks great - thanks for putting it together and apologies for the delay on my end. I'm back in town now :) I only have a couple of comments that I'll leave on the commit, but then should be good to pull in. |
docs/index.md
Outdated
| { "suitename": "E2E", | ||
| "labels": ["fast", "parallel", "component"]} | ||
| ``` | ||
| The custom data can be could accessed like so: |
There was a problem hiding this comment.
Small typo:
"The custom data can be could accessed like so:" => "The custom data can be accessed like so:"
| @@ -25,6 +26,9 @@ func BuildBootstrapCommand() command.Command { | |||
| {Name: "template", KeyPath: "CustomTemplate", | |||
| UsageArgument: "template-file", | |||
| Usage: "If specified, generate will use the contents of the file passed as the bootstrap template"}, | |||
| {Name: "templatedata", KeyPath: "CustomTemplateData", | |||
There was a problem hiding this comment.
could we make this template-data to be more consistent with the rest of Ginkgo's multi-word flags? Thanks!
| @@ -28,6 +29,9 @@ func BuildGenerateCommand() command.Command { | |||
| {Name: "template", KeyPath: "CustomTemplate", | |||
| UsageArgument: "template-file", | |||
| Usage: "If specified, generate will use the contents of the file passed as the test file template"}, | |||
| {Name: "templatedata", KeyPath: "CustomTemplateData", | |||
There was a problem hiding this comment.
could we make this template-data to be more consistent with the rest of Ginkgo's multi-word flags? Thanks!
* Includes updates to docs * Includes associated integration tests
Dannyb48
force-pushed
the
custom_template_data
branch
from
ecee31f
to
1fb06d5
Compare
|
LGTM thanks! I'll merge this in and probably cut a release next week after i finish up a few other things i'm working on. |
