Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Improve converted test descriptions #34

Merged
merged 1 commit into from Feb 10, 2014

Conversation

Projects
None yet
2 participants
Contributor

tjarratt commented Feb 7, 2014

Given

func TestConvertsToGinkgo(t *testing.T) { }

The converted code should be

It("converts to ginkgo", func() { })

Given that unit test names always start with Test and are camel cased, it seemed to me that we could do better to write a much more natural test name for ginkgo convert.

Owner

onsi commented Feb 7, 2014

Awesome!

Owner

onsi commented Feb 9, 2014

@tjarratt looks like Travis didn't like it -- do you mind looking into it?

Improve converted It("converts tests to ginkgo")
Given that unit test names always start with Test and are camel cased, it
seemed to me that we could do better to write a much more natural test name
for `ginkgo convert`.
Contributor

tjarratt commented Feb 10, 2014

Should be all good now.

Owner

onsi commented Feb 10, 2014

Saweet :)

onsi added a commit that referenced this pull request Feb 10, 2014

@onsi onsi merged commit 5aab1d4 into onsi:master Feb 10, 2014

1 check passed

default The Travis CI build passed
Details

@tjarratt tjarratt deleted the tjarratt:improve-it-description branch Feb 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment