From a705b6267003665cb54b0ba7a9ff689e5574bb9d Mon Sep 17 00:00:00 2001 From: Carl Dunham Date: Sat, 14 Jul 2018 00:17:25 -0400 Subject: [PATCH 1/2] docs: fix for contributing instructions --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 420be26b1..908b95c2c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,9 +16,9 @@ Thanks for supporting Ginkgo! Fork the repo, then: ``` -go get https://github.com/onsi/ginkgo +go get github.com/onsi/ginkgo go get github.com/onsi/gomega/... -cd $GOPATH/onsi/ginkgo +cd $GOPATH/src/github.com/onsi/ginkgo git remote add fork git@github.com:/ginkgo.git ginkgo -r -p # ensure tests are green From 699fdc30b9546e809b37cc2eb96278a7cc1f34ad Mon Sep 17 00:00:00 2001 From: Carl Dunham Date: Sat, 14 Jul 2018 00:17:59 -0400 Subject: [PATCH 2/2] fix: for `go vet` to pass --- ginkgo/testrunner/test_runner.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ginkgo/testrunner/test_runner.go b/ginkgo/testrunner/test_runner.go index 5df41be4c..97a83145f 100644 --- a/ginkgo/testrunner/test_runner.go +++ b/ginkgo/testrunner/test_runner.go @@ -367,9 +367,8 @@ func (t *TestRunner) runParallelGinkgoSuite() RunResult { | | | Ginkgo timed out waiting for all parallel nodes to report back! | | | - ------------------------------------------------------------------- -`) - fmt.Println(t.Suite.PackageName, "timed out. path:", t.Suite.Path) + -------------------------------------------------------------------`) + fmt.Println("\n", t.Suite.PackageName, "timed out. path:", t.Suite.Path) os.Stdout.Sync() for _, writer := range writers {