Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pointer support to HaveField matcher #495

merged 1 commit into from Jan 27, 2022


Copy link

@schrej schrej commented Jan 27, 2022

This adds very basic pointer support to the recently added HaveField matcher.

I'm opening this before any feedback on the issue because I did some brief experiments to see how it could be implemented before we opened the issue. The approach might be a little to basic though.

resolves #494

Copy link

onsi commented Jan 27, 2022

this looks good to me! thanks for the PR!

Copy link

onsi commented Jan 27, 2022

(will pull it in once the GitHub actions finish running)

@onsi onsi marked this pull request as ready for review January 27, 2022 19:05
@onsi onsi merged commit 79e41a3 into onsi:master Jan 27, 2022
@schrej schrej deleted the feature/havefield-pointers branch January 28, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Adding pointer support for HaveField
2 participants