Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Go 1.18 #532

Merged
merged 1 commit into from Mar 25, 2022
Merged

Fix for Go 1.18 #532

merged 1 commit into from Mar 25, 2022

Conversation

BooleanCat
Copy link
Contributor

@BooleanCat BooleanCat commented Mar 21, 2022

This PR fixes gomega for Go 1.18 and drops support for Go 1.16 (end of lifed).

Change summary:

  1. Stop testing on 1.16
  2. Test on 1.18
  3. Only check modules are tidy on current version in go.mod (different versions tidy differently).
  4. Fix failing tests
  5. Force GO11MODULE=off for functions that compile test binaries

Fixes #531

@BooleanCat
Copy link
Contributor Author

BooleanCat commented Mar 22, 2022

Looks like the tests are not triggering for some reason.

@onsi
Copy link
Owner

onsi commented Mar 25, 2022

odd - not sure why the tests aren't running. thanks so much for digging into this @BooleanCat and sorry I haven't been able to be more responsive. I'll merge this in and run things locally against 1.18 and cut a new release once I get a few more gomega PRs pulled in.

@onsi onsi merged commit 56d2a29 into onsi:master Mar 25, 2022
@BooleanCat BooleanCat deleted the go118 branch Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants