Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest ginkgo #535

Merged
merged 2 commits into from Apr 26, 2022
Merged

Use latest ginkgo #535

merged 2 commits into from Apr 26, 2022

Conversation

BooleanCat
Copy link
Contributor

@BooleanCat BooleanCat commented Mar 25, 2022

The fun doesn't stop - this change slims down the go.sum significantly because Go 1.18 deals with the circular imports better.

I'll leave this PR in draft until Ginkgo is shipped, at which point I'll point it at the new version.

@onsi
Copy link
Owner

onsi commented Apr 26, 2022

it's shipped!

@BooleanCat BooleanCat marked this pull request as ready for review Apr 26, 2022
@BooleanCat
Copy link
Contributor Author

BooleanCat commented Apr 26, 2022

Sweet, this is good to go.

@onsi
Copy link
Owner

onsi commented Apr 26, 2022

🎉

@onsi onsi merged commit 1c29028 into onsi:master Apr 26, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants