Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search for synonyms #35

Closed
nicolevasilevsky opened this issue Feb 11, 2015 · 19 comments
Closed

search for synonyms #35

nicolevasilevsky opened this issue Feb 11, 2015 · 19 comments

Comments

@nicolevasilevsky
Copy link

Could we add the ability to search for synonyms when searching ontologies in Ontobee?

@cindyJax
Copy link

I would also find such a feature useful.

@ontoden
Copy link
Contributor

ontoden commented Feb 11, 2015

I think Ontobee can already search for synonyms.
You can provide some examples if it is not the case.
Thanks,
Oliver

From: nicolevasilevsky [mailto:notifications@github.com]
Sent: Wednesday, February 11, 2015 4:53 PM
To: ontoden/ontobee
Subject: [ontobee] search for synonyms (#35)

Could we add the ability to search for synonyms when searching ontologies in Ontobee?


Reply to this email directly or view it on GitHubhttps://github.com//issues/35.


Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues

@cindyJax
Copy link

A search for "vertebral body' does not return 'bony vertebral centrum'

A search for 'von Ebner's gland' does not return 'gustatory gland'

From: ontoden <notifications@github.commailto:notifications@github.com>
Reply-To: ontoden/ontobee <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, February 11, 2015 5:09 PM
To: ontoden/ontobee <ontobee@noreply.github.commailto:ontobee@noreply.github.com>
Cc: Cynthia Smith <cynthia.smith@jax.orgmailto:cynthia.smith@jax.org>
Subject: Re: [ontobee] search for synonyms (#35)

I think Ontobee can already search for synonyms.
You can provide some examples if it is not the case.
Thanks,
Oliver

From: nicolevasilevsky [mailto:notifications@github.com]
Sent: Wednesday, February 11, 2015 4:53 PM
To: ontoden/ontobee
Subject: [ontobee] search for synonyms (#35)

Could we add the ability to search for synonyms when searching ontologies in Ontobee?


Reply to this email directly or view it on GitHubhttps://github.com//issues/35.


Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues


Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-73975618.

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.

@ontoden
Copy link
Contributor

ontoden commented Feb 12, 2015

But the term 'bony vertebral centrum' is not a synonym of 'vertebral body':
http://www.ontobee.org/browser/rdf.php?o=VIVO-ISF&iri=http://purl.obolibrary.org/obo/UBERON_0001075

'vertebral body' is indeed a synonym of 'body of vertebra'. The 'body of vertebra' is the label of the term. 'vertebral body' is its synonym. When you search 'vertebral body', Ontobee will return the 'body of vertebra' to you. It indicates that Ontobee can search the synonym.

Oliver


From: cindyJax [notifications@github.com]
Sent: Wednesday, February 11, 2015 7:25 PM
To: ontoden/ontobee
Cc: ontoden
Subject: Re: [ontobee] search for synonyms (#35)

A search for "vertebral body' does not return 'bony vertebral centrum'

A search for 'von Ebner's gland' does not return 'gustatory gland'

From: ontoden <notifications@github.commailto:notifications@github.com>
Reply-To: ontoden/ontobee <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, February 11, 2015 5:09 PM
To: ontoden/ontobee <ontobee@noreply.github.commailto:ontobee@noreply.github.com>
Cc: Cynthia Smith <cynthia.smith@jax.orgmailto:cynthia.smith@jax.org>
Subject: Re: [ontobee] search for synonyms (#35)

I think Ontobee can already search for synonyms.
You can provide some examples if it is not the case.
Thanks,
Oliver

From: nicolevasilevsky [mailto:notifications@github.com]
Sent: Wednesday, February 11, 2015 4:53 PM
To: ontoden/ontobee
Subject: [ontobee] search for synonyms (#35)

Could we add the ability to search for synonyms when searching ontologies in Ontobee?


Reply to this email directly or view it on GitHubhttps://github.com//issues/35.


Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues


Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-73975618.

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.


Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-73994594.


Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues

@nicolevasilevsky
Copy link
Author

Ontobee does not seem to retrieve synonyms from MP. Some examples:

MP Term: increased desmoid tumor incidence
Synonym: musculo-aponeurotic fibromatosis
Synonym: aggressive fibromatosis

MP term: abnormal cochlear hair cell development
Synonym: abnormal auditory hair cell development

image

@cmungall
Copy link

Maybe ontobee doesn't use the oboInOwl vocab?

@ontoden
Copy link
Contributor

ontoden commented Feb 14, 2015

It's possible. Let me check it out.
Oliver


From: Chris Mungall [notifications@github.com]
Sent: Friday, February 13, 2015 6:56 PM
To: ontoden/ontobee
Cc: ontoden
Subject: Re: [ontobee] search for synonyms (#35)

Maybe ontobee doesn't use the oboInOwl vocab?


Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-74348354.


Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues

@cmungall
Copy link

Any progress? This should be trivial?

@ontoden
Copy link
Contributor

ontoden commented Aug 4, 2015

The reason why Ontobee could not retrieve synonyms from MP and UBERON is because these two ontologies and several others used:
has_exact_synonym
http://www.geneontology.org/formats/oboInOwl#hasExactSynonym
for indicating synonyms.

Ontobee by default used IAO:“alternative term” as synonyms.

After we found the issue, I asked Edison to fix it. Thanks, Edison, for working on this.

This should be fixed in Ontobee by Edison for now. Please check out.

It appears that there are three other types of “synonyms”:
has_related_synonym: http://www.geneontology.org/formats/oboInOwl#hasRelatedSynonym
has_narrow_synonym: http://www.geneontology.org/formats/oboInOwl#hasNarrowSynonym
has_broad_synonym: http://www.geneontology.org/formats/oboInOwl#hasBroadSynonym

They appear not “exact”. We don’t know if we want to include these “synonyms” into our synonym searching function. I think we will need to obtain some consensus on this issue first before we implement it.

Oliver

From: nicolevasilevsky [mailto:notifications@github.com]
Sent: Friday, February 13, 2015 2:24 PM
To: ontoden/ontobee
Cc: ontoden
Subject: Re: [ontobee] search for synonyms (#35)

Ontobee does not seem to retrieve synonyms from MP. Some examples:

MP Term: increased desmoid tumor incidence
Synonym: musculo-aponeurotic fibromatosis
Synonym: aggressive fibromatosis

MP term: abnormal cochlear hair cell development
Synonym: abnormal auditory hair cell development

[image]https://cloud.githubusercontent.com/assets/6722114/6193697/b1c17b32-b372-11e4-8d20-6ef5e6867f89.png


Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-74310876.


Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues

@ontoden
Copy link
Contributor

ontoden commented Aug 4, 2015

Hi Chris,
This is the reason.
Edison in my group has now fixed it in Ontobee.
See my previous reply.
Oliver

From: He, Yongqun [mailto:yongqunh@med.umich.edu]
Sent: Friday, February 13, 2015 7:55 PM
To: ontoden/ontobee; ontoden/ontobee
Cc: ontoden
Subject: RE: [ontobee] search for synonyms (#35)

It's possible. Let me check it out.
Oliver


From: Chris Mungall [notifications@github.com]
Sent: Friday, February 13, 2015 6:56 PM
To: ontoden/ontobee
Cc: ontoden
Subject: Re: [ontobee] search for synonyms (#35)

Maybe ontobee doesn't use the oboInOwl vocab?

Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-74348354.


Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues


Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues

@cmungall
Copy link

cmungall commented Aug 4, 2015

Of course you will want to include the other synonym scopes

@linikujp
Copy link

linikujp commented Aug 4, 2015

I suggest that the broader and narrower synonym terms should be included in
the searching query.

In the result section, those types of synonyms should be shown.

Best,
Asiyah

On Tue, Aug 4, 2015 at 4:21 PM, ontoden notifications@github.com wrote:

The reason why Ontobee could not retrieve synonyms from MP and UBERON is
because these two ontologies and several others used:
has_exact_synonym
http://www.geneontology.org/formats/oboInOwl#hasExactSynonym
for indicating synonyms.

Ontobee by default used IAO:“alternative term” as synonyms.

After we found the issue, I asked Edison to fix it. Thanks, Edison, for
working on this.

This should be fixed in Ontobee by Edison for now. Please check out.

It appears that there are three other types of “synonyms”:
has_related_synonym:
http://www.geneontology.org/formats/oboInOwl#hasRelatedSynonym
has_narrow_synonym:
http://www.geneontology.org/formats/oboInOwl#hasNarrowSynonym
has_broad_synonym:
http://www.geneontology.org/formats/oboInOwl#hasBroadSynonym

They appear not “exact”. We don’t know if we want to include these
“synonyms” into our synonym searching function. I think we will need to
obtain some consensus on this issue first before we implement it.

Oliver

From: nicolevasilevsky [mailto:notifications@github.com]
Sent: Friday, February 13, 2015 2:24 PM
To: ontoden/ontobee
Cc: ontoden
Subject: Re: [ontobee] search for synonyms (#35)

Ontobee does not seem to retrieve synonyms from MP. Some examples:

MP Term: increased desmoid tumor incidence
Synonym: musculo-aponeurotic fibromatosis
Synonym: aggressive fibromatosis

MP term: abnormal cochlear hair cell development
Synonym: abnormal auditory hair cell development

[image]<
https://cloud.githubusercontent.com/assets/6722114/6193697/b1c17b32-b372-11e4-8d20-6ef5e6867f89.png>


Reply to this email directly or view it on GitHub<
https://github.com/ontoden/ontobee/issues/35#issuecomment-74310876>.


Electronic Mail is not secure, may not be read every day, and should not
be used for urgent or sensitive issues


Reply to this email directly or view it on GitHub
#35 (comment).

@e4ong1031
Copy link
Contributor

The keyword searching function against has_exact_synonym, has_related_synonym, has_narrow_synonym and has_broad_synonym is now implemented in Ontobee.

@linikujp
Copy link

linikujp commented Aug 4, 2015

Great! Thanks, Edison!
How about the result page?

On Tue, Aug 4, 2015 at 4:48 PM, e4ong1031 notifications@github.com wrote:

The keyword searching function against has_exact_synonym,
has_related_synonym, has_narrow_synonym and has_broad_synonym is now
implemented in Ontobee.


Reply to this email directly or view it on GitHub
#35 (comment).

@ontoden
Copy link
Contributor

ontoden commented Aug 4, 2015

For example,
The term:
http://purl.obolibrary.org/obo/UBERON_0003834
label: thoracic segment blood vessel

has_exact_synonym: thorax blood vessel; blood vessel of thorax
has_related_synonym: upper body blood vessel

Now you can search these synonyms in Ontobee, for example,
http://www.ontobee.org/browser/index.php?keywords=upper+body+blood+vessel&Submit2=Search+terms&o=UBERON

Oliver

From: Asiyah Yu Lin [mailto:notifications@github.com]
Sent: Tuesday, August 04, 2015 4:52 PM
To: ontoden/ontobee
Cc: ontoden
Subject: Re: [ontobee] search for synonyms (#35)

Great! Thanks, Edison!
How about the result page?

On Tue, Aug 4, 2015 at 4:48 PM, e4ong1031 <notifications@github.commailto:notifications@github.com> wrote:

The keyword searching function against has_exact_synonym,
has_related_synonym, has_narrow_synonym and has_broad_synonym is now
implemented in Ontobee.


Reply to this email directly or view it on GitHub
#35 (comment).


Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-127758148.


Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues

@linikujp
Copy link

linikujp commented Aug 4, 2015

Looks good to me.

Thanks!
Asiyah

On Tue, Aug 4, 2015 at 4:55 PM, ontoden notifications@github.com wrote:

For example,
The term:
http://purl.obolibrary.org/obo/UBERON_0003834
label: thoracic segment blood vessel

has_exact_synonym: thorax blood vessel; blood vessel of thorax
has_related_synonym: upper body blood vessel

Now you can search these synonyms in Ontobee, for example,

http://www.ontobee.org/browser/index.php?keywords=upper+body+blood+vessel&Submit2=Search+terms&o=UBERON

Oliver

From: Asiyah Yu Lin [mailto:notifications@github.com]
Sent: Tuesday, August 04, 2015 4:52 PM
To: ontoden/ontobee
Cc: ontoden
Subject: Re: [ontobee] search for synonyms (#35)

Great! Thanks, Edison!
How about the result page?

On Tue, Aug 4, 2015 at 4:48 PM, e4ong1031 <notifications@github.com
mailto:notifications@github.com> wrote:

The keyword searching function against has_exact_synonym,
has_related_synonym, has_narrow_synonym and has_broad_synonym is now
implemented in Ontobee.


Reply to this email directly or view it on GitHub
#35 (comment).


Reply to this email directly or view it on GitHub<
https://github.com/ontoden/ontobee/issues/35#issuecomment-127758148>.


Electronic Mail is not secure, may not be read every day, and should not
be used for urgent or sensitive issues


Reply to this email directly or view it on GitHub
#35 (comment).

@cmungall
Copy link

cmungall commented Aug 4, 2015

@e4ong1031 you rock!

@cmungall
Copy link

cmungall commented Aug 4, 2015

This has been a major issue for ontobee for a while, it's worth calling out this improvement, e.g. in a news page or tweet

@ontoden
Copy link
Contributor

ontoden commented Aug 4, 2015

Good point. I have added this to the Ontobee news page: http://www.ontobee.org/news.php. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants