Not everything gets loaded in rails c

[eugenk]

Logged into the rails c production on ontohub.org, when I execute

ActiveRecord::Base.logger.level = 1; threads = Repository.find_by_path('eugens-test-1').ontologies.where(parent_id: nil).map(&:current_version).map { |ov| Thread.new { ov.parse_full } }.each(&:join)

I get errors that indicate incomplete application loading. It randomly doesn't find classes in the top namespace, like Semaphore, AccessTokenDeletionWorker or TimeoutWorker (raising NameErrors with NameError: uninitialized constant ...). As far as I remember, they all reside in the lib directory. I'm not 100% sure of it, though.

[eugenk]

This also seems to be a problem in Sidekiq.

[eugenk]

Maybe don't _auto_load the lib directory (lazily), but rather eager load it.

[phyrog]

The problem with eager loading lib is that there are some files that are only for command line git and should not be loaded normally. Unfortunately we can only specify directories to be eager loaded, but not files (where we could exclude those). For that to work, we need to split the lib directory into files that should be loaded and those that should not be loaded normally (environment_light.rb is one of those).

[eugenk]

So, now, this is related to #1597.

[tillmo]

This split should be not too difficult?

[phyrog]

I think this is the same problem we're having. The multiple threads are loading the same files at the same time, which is not thread-safe up until Rails 4.2.

We could try to monkey patch the changes in the commit (which is basically just a lock around the loading) into our rails. Rails 3 does not have this method, but instead a config variable. This is by default false, so this does not fix the errors.