Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for JTM 1.0 #151

Closed
GoogleCodeExporter opened this issue Mar 16, 2015 · 12 comments
Closed

Support for JTM 1.0 #151

GoogleCodeExporter opened this issue Mar 16, 2015 · 12 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

We need an exporter for JTM 1.0 which can export fragments, as requested 
by several users. (An importer would also be nice.)Once we have one we 
should also make it available via TMRAP.

Original issue reported on code.google.com by lar...@gmail.com on 13 Nov 2009 at 8:56

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

added a first version of a JTM 1.0 exporter, see r658

Original comment by thomas.n...@gmail.com on 23 Nov 2009 at 4:17

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

JTM importer and exporter are now checked into the trunk, it is already quite 
useful,
though tests have still to be written.

Please send me feedback.

Original comment by thomas.n...@spaceapplications.com on 25 Nov 2009 at 9:41

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

Trying to get to the feedback. :)

For tests I suggest we should use the ones in cxtm-tests.sf.net. There are 
about 130 
tests with baselines there, which should take us quite a long way.

Original comment by lar...@gmail.com on 25 Nov 2009 at 9:47

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

Have looked over the code, and generally it looks very good.

We need a package.html for the package. I also fixed some very minor style 
issues in 
revision 665.

One thing, though: the encoding sniffer does not appear to implement the 
correct 
JSON rules. See section 3 of RFC 4627: http://www.ietf.org/rfc/rfc4627.txt

Original comment by lar...@gmail.com on 25 Nov 2009 at 10:30

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

ah ok, thanks for the hint, I just modified the LTMEncodingSniffer without 
taking
much care.

I will take care of these things.

Original comment by thomas.n...@gmail.com on 25 Nov 2009 at 10:34

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

Good. The Byte Order Mark (BOM) that the LTM code is testing for you can just 
ignore 
in the case of JTM. Notepad will sometimes insert this, but I hope JTM will not 
have 
this issue, since JTM fragments will generally be produced by web services, 
which 
have better ways of identifying the encoding used.

Original comment by lar...@gmail.com on 25 Nov 2009 at 12:06

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

[deleted comment]
@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

I have checked in a JTMTestCaseGenerator that uses the cxtm test suite (similar 
too
the xtm2 tests).

The detached tests are excluded so far, as I have to fix the reader to support 
this.

Original comment by thomas.n...@spaceapplications.com on 4 Dec 2009 at 5:12

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

I have added also jtm writer tests similar to the ltmWriter tests:

 - read the jtm tests from the cxtm test suite
 - write jtm
 - read in the written jtm again
 - write cxtm
 - compare to baseline

All the tests run through (apart from the -detached tests that are skipped by 
now),
though I have to clean up the code and include the streaming tokenizer from 
Lars.

Original comment by thomas.n...@spaceapplications.com on 8 Dec 2009 at 5:05

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

In r739, I improved the JTM import/export support. The JTMTopicMapWriter is now 
fully
documented and cleaned up, and the JTMParser has been improved to support 
detached
constructs as well. Now all of the cxtm tests for jtm successfully run through,
therefore, imo this feature request does not block the release of 5.1 anymore, 
though
the import implementation has to be further improved and documented.

Original comment by thomas.n...@spaceapplications.com on 14 Dec 2009 at 4:48

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

Ok, so I have now added support for a streaming jtm parser, based on the work 
from
Lars Heuer. Tests run all through successfully, in case no one has more 
comments, I
would suggest to set this issue to fixed.

Original comment by thomas.n...@spaceapplications.com on 17 Dec 2009 at 2:15

@GoogleCodeExporter

This comment has been minimized.

Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 16, 2015

I agree. This issue is fixed.

Original comment by lar...@gmail.com on 18 Dec 2009 at 8:31

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.