Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanonicalXTMWriterTestGenerator is not included in test configuration + testdata baseline is outdated #344

Closed
GoogleCodeExporter opened this issue Mar 16, 2015 · 9 comments

Comments

@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Mar 16, 2015

The CanonicalXTMWriterTestGenerator is never used in tests as it is missing 
from test-data/config/tests.xml. Adding it to the test config results in test 
failures since the test-data/cxtm/baseline is outdated. It still contains 
<locator> without newlines, <topicName> instead of <name>, missing <rolePlayed> 
and urls without trailing slash. Reification also differs, but I'm not sure 
about the exact syntax.

I attach 2 patches. Patch1 fixes all issues mentioned (done by hand), except 
reification. Patch2 fixes all issues, but has changes for 6 files [1] that I 
need feedback on. These are files from the out directory, generated by 
CanonicalXTMWriter.

I'll apply changes to config/tests.xml and cxtm/baseline/ after a confirm that 
the syntax in patch 2 is correct. All tests succeed without failures with the 
second patch.

This would have emerged earlier in Maven (it actually originated from the Maven 
branch), since Maven uses convention over configuration. All tests will be 
included automatically without using a config file. Fixing this issue will 
bring us closer to completing the Maven branch.

[1] reified-association.ltm.cxtm, reified-name.ltm.cxtm, 
reified-occurrence.ltm.cxtm, reified-role.ltm.cxtmm, reifytm.ltm.cxtm, 
variant-reified.ltm.cxtm

Original issue reported on code.google.com by p.kruijsen on 17 Jan 2011 at 10:41

Attachments:

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

Further research shows that another 3 files from the topicmaps.xml package are 
not included in config/tests.xml: TMExporterFilterTestCase, 
XTMFragmentExporterTestCase and XTMPathTopicMapSourceTest. Out of date 
directories in test-data that are affected by including these tests are 
filter-tests/baseline and xtmFragmentExporter/baseline. Differences are far 
worse than in cxtm/baseline, so I won't even bother posting a patch.

Original comment by p.kruijsen on 17 Jan 2011 at 3:48

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

I tried looking at this now, but it's fairly tricky with a patch. Could you 
attach the full versions of the six files you want to have checked? Then I can 
verify them.

Original comment by lar...@gmail.com on 28 Jan 2011 at 1:47

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

I've attached the output files that my machine generated by running the tests 
CanonicalXTMWriterTestGenerator, TMExporterFilterTestGenerator and 
XTMFragmentExporterTestGenerator. You can compare these to the baselines 
mentioned earlier. Thanks.

Original comment by p.kruijsen on 28 Jan 2011 at 2:04

Attachments:

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

I went through all the six files now, and they are all correct as far as I can 
see.

I think TMExporterFilterTestCase, XTMFragmentExporterTestCase and 
XTMPathTopicMapSourceTest merit a separate issue each. Otherwise it's going to 
take forever to close this one.

Was that everything you needed to close this issue, or did I miss something?

Original comment by lar...@gmail.com on 28 Jan 2011 at 2:22

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

I've committed the changes to the CXTM testdata baseline in revisions r1607 
(trunk) and r1608 (Maven branch). CanonicalXTMWriterTestGenerator is still not 
included in test-data/config/tests.xml. I'll leave that untouched. I'll open 
separate issues for the other cases.

Original comment by p.kruijsen on 31 Jan 2011 at 8:58

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

Excellent that you also fixed it in trunk! Great if you can make an issue for 
CanonicalXTMWriterTestGenerator being disabled and assign it to me. Then I'll 
see if I can fix it.

Original comment by lar...@gmail.com on 31 Jan 2011 at 9:59

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

Revision r1612 adds CanonicalXTMWriterTestGenerator to 
test-data/config/tests.xml.

Original comment by p.kruijsen on 31 Jan 2011 at 10:29

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

The issues regarding XTMFragmentExporterTestGenerator and 
TMExporterFilterTestGenerator are now filed as issue #353 and issue #354, 
respectively.

Original comment by p.kruijsen on 31 Jan 2011 at 7:17

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

Original comment by qsieb...@gmail.com on 27 Jan 2012 at 10:49

  • Added labels: Release5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant