Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to patched 3rd-party libs #66

Closed
GoogleCodeExporter opened this issue Mar 16, 2015 · 16 comments
Closed

Remove dependency to patched 3rd-party libs #66

GoogleCodeExporter opened this issue Mar 16, 2015 · 16 comments

Comments

@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Mar 16, 2015

If we want to be able to publish ontopia on Maven central repo, we should
not depend on 3rd-party libs we have patched (for various reasons).

We should try to get the patches accepted upstream.

Original issue reported on code.google.com by baard...@gmail.com on 9 Jul 2009 at 11:15

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

From irc.ontopia.net:

< grove> jing.jar we had to patch as it caused an NPE on java6. touchgraph.jar 
we had
to fix som threading issues.

Original comment by baard...@gmail.com on 9 Jul 2009 at 11:16

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

The reason why we had to patch jing.jar is explained in bug 2150 in the old 
issue 
tracker. We submitted the patches to fix touchgraph.jar to the original 
maintainer, 
but never heard back from them.

Original comment by indiapaleale@gmail.com on 9 Jul 2009 at 11:18

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

It seems to me that we should be able to get the jing patches into the main 
Jing 
code by contacting the maintainers.

We could also make another attempt at touchgraph.

Original comment by lar...@gmail.com on 9 Jul 2009 at 11:33

  • Added labels: Component-Build

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

I don't know what bug 2150 is about, but there is also a newer Jing version
available: http://code.google.com/p/jing-trang/downloads/list (20091111)

Unfortunately, it did not make it into a Maven repository yet


Original comment by lars.he...@gmail.com on 7 May 2010 at 2:14

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

Bug 2150 reads:

<pre>
A NullPointerException is thrown from within the DatatypeLibraryLoader class. 
This 
happends because the class is included (for some reason) in the classes.jar 
shipped 
with the JVM. The NPE is then thrown because of class loading issues.

Caused by: java.lang.NullPointerException
        at org.relaxng.datatype.helpers.DatatypeLibraryLoader$Service
$Loader2.getResources(DatatypeLibraryLoader.java:151)
        at org.relaxng.datatype.helpers.DatatypeLibraryLoader$Service.<init>
(DatatypeLibraryLoader.java:173)
        at org.relaxng.datatype.helpers.DatatypeLibraryLoader.<init>
(DatatypeLibraryLoader.java:57)
        at net.ontopia.topicmaps.xml.XTMValidatingContentHandler.createValidator
(XTMValidatingContentHandler.java
:57)
</pre>

Geir Oves comments then go:

Worked around the problem by making a copy of the class named 
DatatypeLibraryLoader2 and adding it to the jing.jar file. The OKS 
has been updated to use this new class instead of the old. 

The new file also added a clt != null check in the 
Loader2.getResource(String) method. The real problem here is that 
the getResource(String) did not work if the class was loaded through 
the boot classloader. 

As for Maven repositories: we could always host it in our own, I suppose.

Original comment by lar...@gmail.com on 11 May 2010 at 7:20

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

[deleted comment]

1 similar comment
@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

[deleted comment]

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

Ad trove: Is it also patched or is the issue the missing Maven support?

Original comment by lars.he...@gmail.com on 18 May 2010 at 11:11

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

No. The trove jar is not patched. We have to host it ourselves as it is not 
hosted 
anywhere else.

Original comment by indiapaleale@gmail.com on 18 May 2010 at 7:47

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

If Jing and trove don't have any other dependancies, you can do the following 
to make 
them available quickly (and easy):

- do a local maven install from file: 
    mvn install:install-file -DgroupId=<MVN_GROUPID> -DartifactId=<MVN_ARTIFACTID> 
-Dversion=<MVN_VERSION> -Dpackaging=jar -Dfile=<JAR_FILE_TO_INSTALL>

- copy the entry in your local repository (userhome/.m2./repository) to the 
online 
repository.

- Try if it works by adding it as dependency to a maven project

Original comment by qsieb...@gmail.com on 19 May 2010 at 9:49

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

Original comment by qsieb...@gmail.com on 30 Sep 2010 at 9:58

  • Added labels: Management-Maven

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

Trove4j is now available in the maven repo as net.sf.trove4j:trove4j. I've 
refactored Ontopia to use this version in r2478.

Original comment by qsieb...@gmail.com on 31 Jul 2013 at 10:31

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

In new Jing sources:

// We use this instead of the one in org.relaxng.datatype.helper because 
tools.jar in Java 6 includes
// org.relaxng.datatype, which messes up class loading for the jing task in 
Ant, when Ant's class loader's
// parent will have tools.jar in its classpath.

Meaning the Jing issue was an Ant classpath issue and fixed in the newer Jing 
versions

Original comment by qsieb...@gmail.com on 31 Jul 2013 at 11:16

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

Upgraded to public Jing 20091111 in r2479.

Original comment by qsieb...@gmail.com on 31 Jul 2013 at 11:25

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

And finally upgraded touchgraph to public graphlayout artifact. The 
modifications that were made were all replacements of new Thread(...) with 
SwingUtils.invokeLater. I tested the vizlet and vizigator and found no issues. 
We can re-examine issues if the resurface. 

Original comment by qsieb...@gmail.com on 31 Jul 2013 at 1:34

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 16, 2015

Removed repository reference for patched libraries in r2485.

Original comment by qsieb...@gmail.com on 31 Jul 2013 at 2:11

  • Changed state: Fixed
  • Added labels: Release5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant