New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if ORO is replacable with java.util.regex #81

Closed
GoogleCodeExporter opened this Issue Mar 16, 2015 · 10 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Mar 16, 2015

Check if Apache ORO is replaceable with java.util.regex 

Original issue reported on code.google.com by lars.he...@gmail.com on 19 Jul 2009 at 3:45

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 16, 2015

It would be wonderful if we could drop that dependency. Every dependency 
dropped is 
a big gain, as far as I'm concerned.

Here are the uses of ORO:
./net/ontopia/Ontopia.java:    checkClass
("org.apache.oro.text.regex.MalformedPatternException", "oro.jar");
./net/ontopia/topicmaps/db2tm/Values.java:import org.apache.oro.text.regex.*;
./net/ontopia/topicmaps/utils/ltm/LTMTopicMapWriter.java:import 
org.apache.oro.text.regex.MalformedPatternException;
./net/ontopia/topicmaps/utils/ltm/LTMTopicMapWriter.java:import 
org.apache.oro.text.regex.Pattern;
./net/ontopia/topicmaps/utils/ltm/LTMTopicMapWriter.java:import 
org.apache.oro.text.regex.Perl5Compiler;
./net/ontopia/topicmaps/utils/ltm/LTMTopicMapWriter.java:import 
org.apache.oro.text.regex.Perl5Matcher;
./net/ontopia/topicmaps/webed/servlets/ProcessServlet.java:import 
org.apache.oro.text.regex.MalformedPatternException;
./net/ontopia/topicmaps/webed/servlets/ProcessServlet.java:import 
org.apache.oro.text.regex.Pattern;
./net/ontopia/topicmaps/webed/servlets/ProcessServlet.java:import 
org.apache.oro.text.regex.Perl5Compiler;
./net/ontopia/topicmaps/webed/servlets/ProcessServlet.java:import 
org.apache.oro.text.regex.Perl5Matcher;
./net/ontopia/topicmaps/webed/webapps/omnieditor/
ShowActionGroupParamRule.java:import org.apache.oro.text.perl.Perl5Util;

Original comment by lar...@gmail.com on 19 Jul 2009 at 3:49

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 16, 2015

I agree. Feel free to replace oro.jar with java.util.regex.

Original comment by indiapaleale@gmail.com on 19 Jul 2009 at 4:08

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 16, 2015

r344 removes the dependency on ORO from the LTM writer.

Original comment by lar...@gmail.com on 20 Jul 2009 at 1:06

  • Added labels: Component-DB2TM, Component-webed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 16, 2015

This issue was updated by r346.

ProcessServlet never used ORO, unused import

Original comment by lars.he...@gmail.com on 20 Jul 2009 at 2:29

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 16, 2015

The ShowActionGroupParamRule class is used by the webed test suite, but I'm not 
sure 
the test suite uses it very much. It's quite possible that one can get rid of 
it 
entirely. (Would be nice if we could.)

DB2TM seems to provide regexp matching to external code. Haven't fully 
understood 
that part of the code yet.

Original comment by lar...@gmail.com on 20 Jul 2009 at 3:41

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 16, 2015

This issue was updated by r347.

Converted ShowActionGroupParamRule to java.util.regex

Original comment by lars.he...@gmail.com on 20 Jul 2009 at 4:52

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 16, 2015

Added a separate issue #86 to decide if ShowActionGroupParamRule is needed at 
all

Original comment by lars.he...@gmail.com on 20 Jul 2009 at 4:56

  • Removed labels: Component-webed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 16, 2015

Removed label by mistake

Original comment by lars.he...@gmail.com on 20 Jul 2009 at 5:15

  • Added labels: Component-webed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 16, 2015

This issue was closed by r348.

Original comment by lars.he...@gmail.com on 20 Jul 2009 at 6:56

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 16, 2015

Original comment by lar...@gmail.com on 1 Sep 2009 at 11:52

  • Added labels: Release5.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment