Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo path construction problem #17

Closed
VincentTam opened this issue Aug 5, 2019 · 0 comments

Comments

@VincentTam
Copy link
Collaborator

commented Aug 5, 2019

Running git grep BaseURL returns a multitude of paths like

<script src = '{{ $.Site.BaseURL }}js/autosize.min.js'></script>
<script src = '{{ $.Site.BaseURL }}js/timeago.js'></script>

Such practice is discouraged in the Hugo Forum question titled Hugo Themes Don'ts.

Never ever hardcode PATHs. Stop constructing URLs in the form of:
{{ .Site.baseURL }}/something right now.

@VincentTam VincentTam self-assigned this Aug 5, 2019

@VincentTam VincentTam referenced this issue Aug 6, 2019

Merged

Improved internal links construction #22

2 of 4 tasks complete

@onweru onweru closed this in #22 Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.