Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing class in Staticman comments? #32

Closed
VincentTam opened this issue Aug 12, 2019 · 3 comments

Comments

@VincentTam
Copy link
Collaborator

commented Aug 12, 2019

Searching "gravatar" in this repo gives four results, 3 SCSS and 1 HTML file. In the Go-HTML template, there's no instance of gravatar as a class name.

<img src = 'https://www.gravatar.com/avatar/{{ .email }}?s=100' alt = 'user icon' class = 'comment_pic'>

Perhaps the class name gravatar should be added back?

@VincentTam VincentTam added the question label Aug 12, 2019

@onweru

This comment has been minimized.

Copy link
Owner

commented Aug 12, 2019

I renamed the gravatar class to something else ; I believe author_pic in the last refactor. I wasn't quite thorough though. Just like in #25, I'm still considering how to move forward with everything.

@onweru

This comment has been minimized.

Copy link
Owner

commented Aug 12, 2019

I renamed the gravatar class to something else ; I believe author_pic in the last refactor. I wasn't quite thorough. Just like #25, I'm still considering how to move forward with everything.

The renaming was to enable me to reuse part of the scss code. You will notice that the author & comment components share a lot of styles.

While there are more elegant ways of achieving the same (e.g sass mixins or extends), programmers tend to be lazy 😄. That joke is quite true in my case.

@VincentTam

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 12, 2019

Thanks for clarifications. Let's drop the "add back class="gravatar"" question because I agree with your last paragraph. 😄

@VincentTam VincentTam closed this Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.