Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace google fonts #84

Open
wants to merge 1 commit into
base: master
from

Conversation

@t-richards
Copy link

commented Aug 25, 2019

As a user of the framework, I expect for the error page template not to reach out for external internet resources by default.

Instead of a webfont, I suggest using the same native font stack as specified by the exception page: https://github.com/crystal-loot/exception_page/blob/063e8106201d526b0c716f68de036864e723ff22/src/exception_page/exception_page.ecr#L30

Before

00-before

After

01-after

@vladfaust

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

That makes perfect sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.