misc cleanup #318

Closed
duckinator opened this Issue Sep 6, 2011 · 9 comments

Comments

Projects
None yet
3 participants
Collaborator

duckinator commented Sep 6, 2011

Also, 19 instances of blah: func~foo (instead of blah: func ~foo, as the rest of rock uses).
Feel free to check with git grep 'func~[a-zA-Z]', but affected files as of now are:

  • sdk/lang/Buffer.ooc
  • sdk/lang/Character.ooc
  • sdk/lang/Exception.ooc
  • sdk/lang/Format.ooc
  • sdk/lang/String.ooc
  • sdk/structs/List.ooc
  • sdk/text/StringTokenizer.ooc
  • source/frontend/Target.ooc
  • source/frontend/compilers/Clang.ooc
  • source/frontend/compilers/Gcc.ooc
  • source/middle/NamespaceDecl.ooc

FIXED.

Member

nddrylliog commented Nov 28, 2011

@duckinator Any chance you might do a pull request with fixes for all those?

Collaborator

duckinator commented Nov 28, 2011

Sure, I'll get on that in ~10m

Member

nddrylliog commented Nov 28, 2011

03:55 AM here, take your time (:

Collaborator

duckinator commented Nov 28, 2011

Target.ooc can't be cleaned how I mentioned (switching those to enums just makes it 100x more hideous).

Cleaning Terminal.ooc as I mentioned means we can't use plain old Ints instead. IMO this is a good thing (assuming you get those numbers right is probably a Bad Idea). What do you think? https://gist.github.com/1399138

EDIT: That code actually won't compile, but I only want you to look at the enums and note that setAttr(Int) no longer will work.
EDIT2: OK THAT'S A BAD IDEA. Fix one thing, break 20. I'll just fix the func~foo ones...

Collaborator

alexnask commented Nov 28, 2011

Also, shouldn't Terminal output use ooc VarArgs and format now that they are available?

Collaborator

duckinator commented Nov 28, 2011

Maybe. I want to focus on other things first, though. (#278, #10, and a few others I haven't looked at recently enough to remember the issue # of)

Collaborator

duckinator commented May 12, 2012

Haha, awesome. Only two instances of func~foo left. PULL REQUEST IMMINENT (...8 months later...)

duckinator added a commit to duckinator/rock that referenced this issue May 12, 2012

duckinator added a commit that referenced this issue May 12, 2012

Merge pull request #383 from duckinator/issue-318-1
func~blah -> func ~blah (Part of #318).

duckinator added a commit to duckinator/rock that referenced this issue May 12, 2012

Single-line version blocks ftw! Fixes another part of #318. Added lin…
…es for openbsd and netbsd but commented them out for now.

duckinator added a commit that referenced this issue May 12, 2012

Merge pull request #384 from duckinator/issue-318-2
Single-line version blocks ftw! Fixes another part of #318.
Collaborator

duckinator commented Jun 19, 2012

I'm going to close this, because I feel a thorough cleanup through all of rock is inevitable around the time we end up merging conspiracy and master. This also currently serves no purpose except as a general "hey, clean up some code every once in a while!" reminder, since I've tried both of the remaining ideas here and found them to be not worth the hassle (and possibly having bad side effects).

@duckinator duckinator closed this Jun 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment