Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add 'Imports' to .use files? #329

Closed
nddrylliog opened this Issue Sep 14, 2011 · 13 comments

Comments

Projects
None yet
4 participants
Member

nddrylliog commented Sep 14, 2011

I was against it a year back but now I can see how it would actually be useful.

Member

nddrylliog commented Sep 14, 2011

However, as a safety measure, said Imports should be restricted to the SourcePath specified in the .use file

Owner

fredreichbier commented Sep 14, 2011

Sounds good! Maybe use this for the "basic" modules that need to be imported in order to use the module anyway, and let the user import specific other modules by hand? Like ... Imports: mycompiler in the usefile, and import mycompiler/backend/C in the ooc files?

Member

nddrylliog commented Sep 14, 2011

Something like this, yes. Well, the 'Imports:' line should support the same syntax as 'import' itself imho so a package owner could put pretty much anything in his .use file, but the intended use is only the main modules, yes.

Owner

fredreichbier commented Sep 14, 2011

Sure! Something like Imports: mycompiler/Foo, mycompiler/Bar, mycompiler/[Gnuz,Buz] then?

Member

nddrylliog commented Sep 14, 2011

Exactly.

Collaborator

duckinator commented Sep 14, 2011

Sounds good! And I'll just subtly mention #241 here since it's somewhat related... ;P

Collaborator

duckinator commented Feb 16, 2013

We have this now, don't we?

Collaborator

duckinator commented Feb 16, 2013

Imports: ruby/ruby, ruby/rubyvalue-def, ruby/ruby-def

Why yes we do. I actually use it.

@duckinator duckinator closed this Feb 16, 2013

Member

nddrylliog commented Feb 16, 2013

@duckinator I think it wasn't closed because of that:

However, as a safety measure, said Imports should be restricted to the SourcePath specified in the .use file

But that could be another issue, you know.

Collaborator

shamanas commented Feb 16, 2013

@nddrylliog It is already another issue, #523

Collaborator

duckinator commented Feb 16, 2013

How convenient! Let's just pretend I actually checked for that, then. ;)

Member

nddrylliog commented Feb 16, 2013

Ah, high-five to past-@nddrylliog.

Member

nddrylliog commented Nov 23, 2013

So, 3 years back I was against this feature, 2 years back I warned that imports should be sandboxed, today I actually implemented sandboxing. So there you go, @duckinator, @shamanas & @fredreichbier. (And past-@nddrylliog).

(see 1d370d4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment