New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OrderedMultiMap for function resolution #744

Closed
nddrylliog opened this Issue Nov 29, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@nddrylliog
Member

nddrylliog commented Nov 29, 2013

Right now we're iterating through HashMaps and comparing names which:

  • defeats the pupose of the HashMap
  • generates a lot of garbage
  • is expensive time-wise - both for collecting the garbage we generated and just for going through each key in general.

I'm adding tests for OrderedMultiMap first, though. It's already used in other parts of rock, but... can't be too sure.

@ghost ghost assigned nddrylliog Nov 29, 2013

@nddrylliog

This comment has been minimized.

Member

nddrylliog commented Dec 1, 2013

Or just MultiMap..

@nddrylliog

This comment has been minimized.

Member

nddrylliog commented Dec 1, 2013

TypeDecl uses that now.

@nddrylliog nddrylliog closed this Dec 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment