[fancy_backtrace] Comparison of unsigned expression < 0 is always false #779

Closed
fasterthanlime opened this Issue Jul 12, 2014 · 0 comments

Projects

None yet

1 participant

@fasterthanlime
Collaborator

Caught by clang in #778,

This line causes a warning - num_symbols is unsigned, it should be at least signed (and, according to some other bfd_* usage on the web, long).

As a result, we probably can't detect when we fail to read symbols from object files.

@fasterthanlime fasterthanlime added a commit that referenced this issue Aug 15, 2014
@fasterthanlime fasterthanlime Fix types of size, num_symbols in fancy_backtrace. Close #779
What it doesn't fix, though is the fact that libiberty isn't shipped
by homebrew's binutils anymore, cf:
Homebrew/legacy-homebrew#20760
and https://gcc.gnu.org/onlinedocs/libiberty/Using.html#Using

Apparently we should be shipping our own sources, but seeing our
delicate build process, it seems unrealistic for now.
b18f723
@fasterthanlime fasterthanlime added this to the 0.9.9 milestone Aug 15, 2014
@fasterthanlime fasterthanlime self-assigned this Aug 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment