Fixes array error reporting #343

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Collaborator

alexnask commented Nov 27, 2011

Testing this a bit later, cannot right now D:
But it seems about right :)

Should fix array error reporting (yes, its as simple as that :D), see…
…ms to have been broken with the String changes and immutable methods, will test it later.
Collaborator

alexnask commented Nov 27, 2011

Works right, you can test it with this simple code

[1,2,3] method()
Member

nddrylliog commented Nov 27, 2011

Oh blimey. That's a dumb mistake!

runs git blame

@fredreichbier, you're guilty!

Actually don't make an 's' variable, if ternary expression behave funny, make a match or whatever.

Collaborator

alexnask commented Nov 27, 2011

Ok changing to a ternary right now :D

Member

nddrylliog commented Nov 27, 2011

@shamanas nonono! it didn't work with ternary cause the toString() inside still got called (because of generics and whatnot). Return a match instead!

Owner

fredreichbier commented Nov 27, 2011

I don't think you can change this to a ternary, that's the reason I wrote this code in the first place, due to #311. Match is the way to go :)

Also, IMFF indeed :(

Member

nddrylliog commented Nov 27, 2011

All done! Closing.

@nddrylliog nddrylliog closed this Nov 27, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment