Remove DeviceCommsEvent #435

Closed
wants to merge 29 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

swarbhanu commented Dec 26, 2012

The transform that monitors the platform agent will only use DeviceStatusEvent. Both OK and OUT_OF_RANGE status will be sent using the latter event.

DeviceCommsEvent is removed from the system.

swarbhanu added some commits Dec 20, 2012

Fixed uns test and got alert transform aligned to publish one DeviceS…
…tatusEvent each time the first good or bad granule arrives
Got the test working for the transform. but need to remove the gevent…
… sleep and check why finding events through type is not working

@ghost ghost assigned MauriceManning Jan 11, 2013

Owner

mmeisinger commented Jan 11, 2013

What's the status of this PR?

Contributor

swarbhanu commented Jan 11, 2013

I am closing the PR for now to be opened later if needed. In the last week or so, there has been several code pushed in concerning fetching communication status which I think is also used in the UI for status rollups. Though a couple of weeks ago, Maurice and Tim wanted DeviceCommsEvent to be removed, I think we need more discussion on this as a lot of communication status related stuff that has been recently added will now break. Hence closing this pull request for now until further discussion.

@swarbhanu swarbhanu closed this Jan 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment