Adds out of band retrieval and bugfix for replay. #444

Merged
merged 1 commit into from Jan 9, 2013

Conversation

Projects
None yet
2 participants
Member

lukecampbell commented Jan 4, 2013

  • Adds out of band retrieve classmethod.
  • Moves coverage closing to a finally block in a try except, very
    important.

Part of OOIION-645: Data Retriever Latency

Adds out of band retrieval and bugfix for replay.
- Adds out of band retrieve classmethod.
- Moves coverage closing to a finally block in a try except, very
  important.
except Exception as e:
import traceback
traceback.print_exc(e)
raise BadRequest('Problems reading from the coverage')
+ finally:
+ coverage.close(timeout=5)
@lukecampbell

lukecampbell Jan 4, 2013

Member

This is really important if an exception is raised here, the coverage would never be closed... not good and could cause corruption of persisted datasets.

+ coverage.close(timeout=5)
+ return rdt.to_granule()
+
+
@lukecampbell

lukecampbell Jan 4, 2013

Member

This method was added (in lieu of modifying the existing method) to provide clients with the capability of retrieving datasets from the filesystem directly out of band.

@@ -523,3 +524,18 @@ def test_repersist_data(self):
self.assertTrue(success)
+
+ def test_out_of_band_retrieve(self):
@lukecampbell

lukecampbell Jan 4, 2013

Member

Simple integration test that mimics an existing retrieve test, not extremely comprehensive.

Member

blazetopher commented Jan 9, 2013

Reviewed. Addresses the DM portion of OOIION-645

blazetopher added a commit that referenced this pull request Jan 9, 2013

Merge pull request #444 from lukecampbell/oob_retrieval
Adds out of band retrieval and bugfix for replay.

@blazetopher blazetopher merged commit 0a837ca into ooici:master Jan 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment