Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bump to kazoo 1.1 #23

Open
wants to merge 1 commit into from

2 participants

@oldpatricka

No description provided.

@labisso
Collaborator

I had made a couple other fixes when I played with bumping to 1.0, check eae84f3 (in kazoobump branch). I think the key difference is that from 1.0, each KazooClient leaks a pipe filehandle unless you call close().

@oldpatricka

Oh that's very helpful, thanks a @labisso.

@oldpatricka

He @labisso, I tried that patch, but it seems like maybe there's some problem there? When I include it, that close method fails:

Traceback (most recent call last):
  File "/Users/patricka/ooi/epu/epu/processdispatcher/test/test_processdispatcher_service.py", line 76, in tearDown
    self.teardown_store()
  File "/Users/patricka/ooi/epu/epu/processdispatcher/test/test_processdispatcher_service.py", line 1701, in teardown_store
    self.store.shutdown()
  File "/Users/patricka/ooi/epu/epu/processdispatcher/store.py", line 829, in shutdown
    self.kazoo.close()
  File "/Users/patricka/.virtualenvs/epunewkazoo/lib/python2.7/site-packages/kazoo-1.1-py2.7.egg/kazoo/client.py", line 485, in close
    self._connection.close()
  File "/Users/patricka/.virtualenvs/epunewkazoo/lib/python2.7/site-packages/kazoo-1.1-py2.7.egg/kazoo/protocol/connection.py", line 177, in close
    os.close(self._write_pipe)
TypeError: an integer is required
@labisso
Collaborator

Seems like that error is what happens when you call close() on a client that has not been start()ed. I don't remember having that problem (but maybe that is why I called the commit a WIP). Maybe something has changed?

@oldpatricka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 16, 2013
  1. @oldpatricka
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  epu/highavailability/test/test_highavailability_service.py
View
2  epu/highavailability/test/test_highavailability_service.py
@@ -145,7 +145,7 @@ def _get_proc_from_pd(self, upid, pd_name):
def _assert_n_processes(self, n, timeout=None, only_pd=None):
if not timeout:
# HA service works every 5s, so should take no longer than 60s
- timeout = 60
+ timeout = 120
processes = None
for i in range(0, timeout):
processes = self.haservice.core.managed_upids
Something went wrong with that request. Please try again.