Bump to kazoo 1.1 #23

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

oldpatricka commented Jul 15, 2013

No description provided.

Member

labisso commented Jul 15, 2013

I had made a couple other fixes when I played with bumping to 1.0, check eae84f3 (in kazoobump branch). I think the key difference is that from 1.0, each KazooClient leaks a pipe filehandle unless you call close().

Contributor

oldpatricka commented Jul 15, 2013

Oh that's very helpful, thanks a @labisso.

Contributor

oldpatricka commented Jul 15, 2013

He @labisso, I tried that patch, but it seems like maybe there's some problem there? When I include it, that close method fails:

Traceback (most recent call last):
  File "/Users/patricka/ooi/epu/epu/processdispatcher/test/test_processdispatcher_service.py", line 76, in tearDown
    self.teardown_store()
  File "/Users/patricka/ooi/epu/epu/processdispatcher/test/test_processdispatcher_service.py", line 1701, in teardown_store
    self.store.shutdown()
  File "/Users/patricka/ooi/epu/epu/processdispatcher/store.py", line 829, in shutdown
    self.kazoo.close()
  File "/Users/patricka/.virtualenvs/epunewkazoo/lib/python2.7/site-packages/kazoo-1.1-py2.7.egg/kazoo/client.py", line 485, in close
    self._connection.close()
  File "/Users/patricka/.virtualenvs/epunewkazoo/lib/python2.7/site-packages/kazoo-1.1-py2.7.egg/kazoo/protocol/connection.py", line 177, in close
    os.close(self._write_pipe)
TypeError: an integer is required
Member

labisso commented Jul 16, 2013

Seems like that error is what happens when you call close() on a client that has not been start()ed. I don't remember having that problem (but maybe that is why I called the commit a WIP). Maybe something has changed?

Contributor

oldpatricka commented Jul 16, 2013

Ok, thanks

On 2013-07-15, at 5:42 PM, David LaBissoniere notifications@github.com wrote:

Seems like that error is what happens when you call close() on a client that has not been start()ed. I don't remember having that problem (but maybe that is why I called the commit a WIP). Maybe something has changed?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment