check for missing args that led to "(fix) Broken preload" #203

Merged
merged 1 commit into from Jan 11, 2013

Conversation

Projects
None yet
3 participants
Contributor

newbrough commented Dec 11, 2012

Cannot specify object_type or subject_type without predicate when following associations.

@daf daf commented on the diff Dec 12, 2012

pyon/datastore/couchdb/couchdb_datastore.py
if type(id_only) is not bool:
raise BadRequest('id_only must be type bool, not %s' % type(id_only))
if not subject:
raise BadRequest("Must provide subject")
+ if object_type and not predicate:
+ raise BadRequest("Cannot provide object type without a predictate")
@daf

daf Dec 12, 2012

Contributor

Minor quibble, typo here :)

Contributor

daf commented Dec 12, 2012

Looks correct.

Owner

mmeisinger commented Jan 11, 2013

What's the status of this PR? If good please merge

daf merged commit c8f5004 into ooici:master Jan 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment