Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for not writing to disk and fetching measurements f… #189

Merged
merged 5 commits into from
Jan 11, 2021
Merged

Implement support for not writing to disk and fetching measurements f… #189

merged 5 commits into from
Jan 11, 2021

Conversation

hellais
Copy link
Member

@hellais hellais commented Jan 11, 2021

…rom the API

@hellais
Copy link
Member Author

hellais commented Jan 11, 2021 •
edited
Loading

TODO:

  • ooni/probe-engine does not support the raw_measurement API
  • if the API is blocked, it will not work to download the measurement even if it was uploaded (using something like cloudfront)

@hellais hellais marked this pull request as ready for review January 11, 2021 14:28
bassosimone
bassosimone approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

internal/database/actions.go Outdated Show resolved Hide resolved
@bassosimone
Copy link
Contributor

Thank you for working on this, @hellais! I am going to merge as soon as automatic checks are green!

@bassosimone
Copy link
Contributor

This PR implements ooni/probe#1313.

@bassosimone bassosimone merged commit af4cbd1 into master Jan 11, 2021
@bassosimone bassosimone deleted the no-write-disk branch January 11, 2021 18:59
@bassosimone bassosimone mentioned this pull request Jan 11, 2021
Closed
ainghazal pushed a commit to ainghazal/probe-cli that referenced this pull request Mar 8, 2022
@hellais @bassosimone
Implement support for not writing to disk and fetching measurements f… (
8bacb13 
ooni#189)

* Implement support for not writing to disk and fetching measurements from the API

* Handle case of input not being set

* Comment about exposing raw_measurement in probe-engine

* Add basic test for GetMeasurementJSON

* Update internal/database/actions.go

Co-authored-by: Simone Basso <bassosimone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellais @bassosimone