Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show confirmation dialog before stopping test #156

Merged
merged 6 commits into from Sep 8, 2020

Conversation

sarathms
Copy link
Contributor

Fixes ooni/probe#1205
Screenshot from 2020-06-26 01-19-14

I used the same style we use in the onboarding screens. I tried using the buttons from our design system, but dropped it later.
Screenshot from 2020-06-26 00-47-24

Also fixes the bug where the currently running test name wasn't being shown.
Screenshot from 2020-06-26 01-19-08

@sarathms sarathms requested a review from hellais June 26, 2020 05:21
@hellais
Copy link
Member

hellais commented Jun 29, 2020

We should be using a different modal styling for this.

The pattern for the modal in the onboarding is specific for the quiz.

Here is what needs to change:

  • Invert the buttons to have OK on the right and cancel on the left.
  • Make the background color of the modal be white
  • Primary button (OK) should be blue background with white text, secondary button (cancel) should be blue on white
  • Text should all be black

The copy also is a bit weird. Did @agrabeli review it?

@hellais
Copy link
Member

hellais commented Jun 29, 2020

Here is a quick mockup of how it should look like:

Screenshot 2020-06-29 at 17 51 44

Important things to keep in mind for the implementation:

  • Adding shadow around the modal box to give sense of depth
  • Ensure that the tap target around the cancel button is as bug as the OK button and it highlights when mouse over (i.e. it's actually a button with a white background and blue text, like the other one)

@sarathms
Copy link
Contributor Author

Are we not using the Button style from ooni-components?

@hellais
Copy link
Member

hellais commented Jul 17, 2020

Are we not using the Button style from ooni-components?

Yes, if you already have a button component, use that.

Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in my previous comment:

• Invert the buttons to have OK on the right and cancel on the left.
• Make the background color of the modal be white
• Primary button (OK) should be blue background with white text, secondary button (cancel) should be blue on white
• Text should all be black
• The copy also is a bit weird. Did @agrabeli review it?

@sarathms sarathms requested a review from hellais August 20, 2020 21:06
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to look good.

One minor thing which should be fixed is the mouse-over on the close button:
Screenshot 2020-08-21 at 17 31 57

It should not have that blue box around it, but should rather just become a darker X.

@sarathms
Copy link
Contributor Author

Replaced with a custom one with pointer cursor and light color change on hover.

Screenshot from 2020-08-21 12-28-49

@sarathms sarathms requested a review from hellais August 24, 2020 16:18
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

For me it's good to go!

🐳

@sarathms sarathms merged commit 0661312 into master Sep 8, 2020
@sarathms sarathms deleted the ux/stoptest-confirmation branch September 8, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants