Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

probeservices: make sure we can get a compressed check-in response #2379

Closed
4 tasks done
Tracked by #1291
, #2362
...
bassosimone opened this issue Dec 7, 2022 · 1 comment
Closed
4 tasks done
Tracked by #1291
, #2362
...

probeservices: make sure we can get a compressed check-in response #2379

bassosimone opened this issue Dec 7, 2022 · 1 comment
Assignees
@bassosimone
Labels
enhancement improving existing code or new feature funder/drl2022-2024 ooni/probe-engine priority/high testing

Comments

@bassosimone
Copy link
Member

bassosimone commented Dec 7, 2022 •
edited

This issue is about coordinating with @FedericoCeratto to ensure we can receive compressed check-in responses from the backend. To this end, on the probe side, we need to (1) send Accept-Encoding: gzip and (2) handle Content-Encoding: gzip. On the backend side, instead, we need to enable Nginx to compress responses.

  • Send Accept-Encoding: gzip
  • Enable compression on the backend side
  • Handle Content-Encoding: gzip
  • Adjust tests (if needed)
@bassosimone bassosimone mentioned this issue Dec 7, 2022
Closed
9 tasks
@bassosimone bassosimone self-assigned this Dec 7, 2022
bassosimone added a commit to ooni/probe-cli that referenced this issue Dec 9, 2022
@bassosimone
refactor(httpapi): logger belongs to endpoint
b5aa1d4 
This diff changes httpapi Endpoint and Descriptor such that the
logger field is part of the Endpoint rather than Descriptor.

This changes makes sense because the logger to use should be the
same for every API call. What matters, instead, is whether to log
bodies, which remains a property of the API Descriptor.

While I authored this diff originally as part of the work done
in #997, it seems it's
required in #1002 as well.

Hence, the reference issue is ooni/probe#2379.
@bassosimone bassosimone mentioned this issue Dec 9, 2022
Merged
4 tasks
bassosimone added a commit to ooni/probe-cli that referenced this issue Dec 9, 2022
@bassosimone
refactor(httpapi): logger belongs to endpoint (#1003)
cd868c7 
This diff changes httpapi Endpoint and Descriptor such that the
logger field is part of the Endpoint rather than Descriptor.

This changes makes sense because the logger to use should be the
same for every API call. What matters, instead, is whether to log
bodies, which remains a property of the API Descriptor.

While I authored this diff originally as part of the work done
in #997, it seems it's
required in #1002 as well.

Hence, the reference issue is ooni/probe#2379.

While there, fix the go1.19 build workflow, which was broken
by using actions/setup-go rather than downloading go manually.
@bassosimone bassosimone mentioned this issue Dec 9, 2022
Merged
4 tasks
bassosimone added a commit to ooni/probe-cli that referenced this issue Dec 14, 2022
@bassosimone
feat(probeservices): handle gzipped check-in responses (#1002)
8df1173 
See ooni/probe#2379
@bassosimone
Copy link
Member Author

All done!

@bassosimone bassosimone mentioned this issue Oct 4, 2023
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
enhancement improving existing code or new feature funder/drl2022-2024 ooni/probe-engine priority/high testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone