Skip to content
Browse files

Center approve banner text and size buttons consistently.

Fixes #266.
  • Loading branch information...
1 parent e305fea commit 6a13f85a76452bb5b695dedfdce78fff95f9f671 @cespare cespare committed Jul 13, 2012
Showing with 13 additions and 8 deletions.
  1. +3 −0 public/css/diff_view.scss
  2. +10 −8 views/commit.erb
View
3 public/css/diff_view.scss
@@ -76,7 +76,10 @@
@include box(vertical, center, end);
@include box-flex(1);
+ #approvalGroup { width: 160px; }
+
button {
+ width: 100%;
display: block;
font-size: 14px;
white-space: nowrap;
View
18 views/commit.erb
@@ -34,16 +34,18 @@
</div>
<div id="metadataButtons">
- <% if current_user %>
+ <div id="approvalGroup">
+ <% if current_user %>
+ <% if commit.approved? %>
+ <button id="disapproveButton" class="fancy" title="ಠ_ಠ">Disapprove Commit</button>
+ <% else %>
+ <button id="approveButton" class="fancy">Approve Commit</button>
+ <% end %>
+ <% end %>
<% if commit.approved? %>
- <button id="disapproveButton" class="fancy" title="ಠ_ಠ">Disapprove Commit</button>
- <% else %>
- <button id="approveButton" class="fancy">Approve Commit</button>
+ <%= erb :_approved_banner, :layout => false, :locals => { :commit => commit } %>
<% end %>
- <% end %>
- <% if commit.approved? %>
- <%= erb :_approved_banner, :layout => false, :locals => { :commit => commit } %>
- <% end %>
+ </div>
<div id="minorButtons">
<% if current_user %>
<button id="requestReviewButton" class="standard">Request Review</button>

0 comments on commit 6a13f85

Please sign in to comment.
Something went wrong with that request. Please try again.