Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Changes to symbolic links are not shown in the diff view #14

Closed
philc opened this Issue Sep 1, 2011 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

bkad commented Sep 1, 2011

I'll tackle this

@bkad bkad was assigned Sep 7, 2011

@bkad bkad closed this Sep 30, 2011

@bkad bkad reopened this Oct 1, 2011

Contributor

bkad commented Oct 1, 2011

c7e825d introduces a huge diff bug, the unified diff format is different for commit.show vs commit.diffs

Contributor

bkad commented Oct 5, 2011

Problem is harder than I thought. commit.show uses native git while commit.diffs uses pure ruby to get diff info. .show has all the info we need, but the diff format is hard to parse, and is intended more for human readability. .diffs lacks info for renamed files, symlinks and new empty files.

An approach I've taken to fix this is using the native git diff to fetch all the metadata about what files have been renamed/deleted/new, what blobs are involved, etc. and wrapping it in a diff generated by pure ruby which is easier to parse. I've pushed the fix to the native-diff branch

The downside is, we're now shelling out, sacrificing performance for the extra diff info. The longer term solution would be to patch the quick_diff functionality in grit to actually get the missing diff info.

Contributor

bkad commented Oct 6, 2011

fixed in fcbc4c4

@bkad bkad closed this Oct 6, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment