Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Autocomplete branches #223

Closed
cespare opened this Issue Apr 26, 2012 · 3 comments

Comments

Projects
None yet
3 participants
Collaborator

cespare commented Apr 26, 2012

It would be nice to autocomplete branch names if the repos have been specified earlier in the query string.

lyahdav added a commit to lyahdav/barkeep that referenced this issue Aug 8, 2012

Autocomplete branches in search. Implements feature requested in issue
…#223.

- The regex in the get "/autocomplete/branches" on the remote.name is not ideal. I tried using Grit to get branch names rather than remotes, but this doesn't include remote branches and searches are allowed on branches that aren't local. Maybe there's a cleaner solution to this I'm overlooking.
- Because I'm querying Grit for remotes and not branches, it includes "HEAD", which I have to exclude explicitly. Again, maybe there's a cleaner solution.
Contributor

Fandekasp commented Nov 28, 2012

Could we get that feature merged in the official repo ? thanks in advance !

philc added a commit that referenced this issue Feb 28, 2013

Merge pull request #303 from lyahdav/autocomplete_branches
Autocomplete branches in search. Implements feature requested in issue #223.
Contributor

funglaub commented Mar 8, 2013

Thanks for adding this feature. Much appreciated.

Contributor

Fandekasp commented Mar 8, 2013

That is great, thanks :)

@cespare cespare closed this Mar 9, 2013

irabinovitch pushed a commit to irabinovitch/barkeep that referenced this issue Aug 15, 2013

Autocomplete branches in search. Implements feature requested in issue
…#223.

- The regex in the get "/autocomplete/branches" on the remote.name is not ideal. I tried using Grit to get branch names rather than remotes, but this doesn't include remote branches and searches are allowed on branches that aren't local. Maybe there's a cleaner solution to this I'm overlooking.
- Because I'm querying Grit for remotes and not branches, it includes "HEAD", which I have to exclude explicitly. Again, maybe there's a cleaner solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment