Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Autocomplete branches #223

Closed
cespare opened this Issue · 3 comments

3 participants

Caleb Spare Adrien Lemaire Florian Unglaub
Caleb Spare
Collaborator

It would be nice to autocomplete branch names if the repos have been specified earlier in the query string.

Liron Yahdav lyahdav referenced this issue from a commit in lyahdav/barkeep
Liron Yahdav lyahdav Autocomplete branches in search. Implements feature requested in issue
…#223.

- The regex in the get "/autocomplete/branches" on the remote.name is not ideal. I tried using Grit to get branch names rather than remotes, but this doesn't include remote branches and searches are allowed on branches that aren't local. Maybe there's a cleaner solution to this I'm overlooking.
- Because I'm querying Grit for remotes and not branches, it includes "HEAD", which I have to exclude explicitly. Again, maybe there's a cleaner solution.
9300693
Adrien Lemaire

Could we get that feature merged in the official repo ? thanks in advance !

Florian Unglaub

Thanks for adding this feature. Much appreciated.

Adrien Lemaire

That is great, thanks :)

Caleb Spare cespare closed this
irabinovitch irabinovitch referenced this issue from a commit in irabinovitch/barkeep
Liron Yahdav lyahdav Autocomplete branches in search. Implements feature requested in issue
…#223.

- The regex in the get "/autocomplete/branches" on the remote.name is not ideal. I tried using Grit to get branch names rather than remotes, but this doesn't include remote branches and searches are allowed on branches that aren't local. Maybe there's a cleaner solution to this I'm overlooking.
- Because I'm querying Grit for remotes and not branches, it includes "HEAD", which I have to exclude explicitly. Again, maybe there's a cleaner solution.
c52eb05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.