Skip to content

Refactor lambda source code #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jul 22, 2022
Merged

Refactor lambda source code #7

merged 35 commits into from
Jul 22, 2022

Conversation

@xshot9011
Copy link
Contributor

@xshot9011 xshot9011 commented Jun 9, 2022

  • Remove upload code from s3
  • Refactor terraform code

@xshot9011 xshot9011 requested a review from a team June 9, 2022 17:18
@xshot9011 xshot9011 self-assigned this Jun 9, 2022
@xshot9011 xshot9011 linked an issue Jun 9, 2022 that may be closed by this pull request
Refactor lambda source code #6
Closed
@xshot9011 xshot9011 changed the title Refactor/lambda source code Refactor lambda source code Jun 9, 2022
lycbrian
lycbrian approved these changes Jul 1, 2022
View reviewed changes
waruwat-dev
waruwat-dev reviewed Jul 18, 2022
View reviewed changes
@bemillenium
Copy link
Contributor

bemillenium commented Jul 22, 2022

Please add example in example/simple

@xshot9011 xshot9011 merged commit 14f2f4f into main Jul 22, 2022
@xshot9011 xshot9011 deleted the refactor/lambda-source-code branch July 22, 2022 09:19
be99inner
be99inner reviewed Jul 22, 2022
View reviewed changes
Copy link

@be99inner be99inner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave empty terraform files in example code?

  • variables.tf
  • outputs.tf

In my opinion, It should not be empty to give us more professional

@xshot9011
Copy link
Contributor Author

xshot9011 commented Jul 22, 2022

P LAKAKAKAKAKAKAKK

@xshot9011
Copy link
Contributor Author

xshot9011 commented Jul 22, 2022

I JUST MERGE IT BRO

@xshot9011
Copy link
Contributor Author

xshot9011 commented Jul 22, 2022

@be99inner I follow in EFS

@xshot9011
Copy link
Contributor Author

xshot9011 commented Jul 22, 2022

@be99inner After talking with mai and m and art
I change this one
dd15b75
to the present one

xshot9011 added a commit that referenced this pull request Jul 22, 2022
@xshot9011
Revert "Refactor lambda source code (#7)"
0daebd8 
This reverts commit 14f2f4f.
@xshot9011 xshot9011 mentioned this pull request Jul 22, 2022
Merged
xshot9011 added a commit that referenced this pull request Jul 22, 2022
@xshot9011
Revert "Refactor lambda source code (#7)" (#10)
85b21e6 
This reverts commit 14f2f4f.
@xshot9011 xshot9011 restored the refactor/lambda-source-code branch July 22, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@be99inner be99inner be99inner left review comments

@waruwat-dev waruwat-dev waruwat-dev approved these changes

@lycbrian lycbrian lycbrian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xshot9011 xshot9011

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor lambda source code

6 participants

@xshot9011 @bemillenium @be99inner @waruwat-dev @lycbrian