Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window #28

Closed
wants to merge 4 commits into from
Closed

Window #28

wants to merge 4 commits into from

Conversation

nicolaracco
Copy link
Contributor

A raw version of Window. I didn't know how to test #width and #height behaviour, so I inserted two pendings

require 'opal-jquery/document'
require 'opal-jquery/element'
require 'opal-jquery/event'
require 'opal-jquery/http'
require 'opal-jquery/kernel'
require 'opal-jquery/kernel'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 whitespace police has been alerted

@elia
Copy link
Member

elia commented Oct 9, 2013

Merging, but not completely, I'll leave out the #width and #height methods since jquery already provides them.
Changing the behavior (and even fixing jquery bugs) sounds like breaking expectations.

Maybe the implementation is still valuable for opal-browser, cc @meh.

@elia elia closed this Oct 9, 2013
@elia
Copy link
Member

elia commented Oct 9, 2013

cherry-picked 71512c6

@meh
Copy link
Member

meh commented Oct 10, 2013

@elia it's already done in opal-browser 🐼

@elia
Copy link
Member

elia commented Oct 10, 2013

@meh 'course its done, how can I have doubted it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants