Skip to content

Commit a8d4093

Browse files
committed
Remove some more stub files now that opal parses them correctly
1 parent 3d40ed9 commit a8d4093

File tree

4 files changed

+5
-12
lines changed

4 files changed

+5
-12
lines changed

README.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,18 +46,6 @@ opal has to include all dependencies into build.
4646

4747
* **line 171**: `&::Time.method(:now)` doesnt work so wrong method is set
4848

49-
### rspec/core/example_group.rb
50-
51-
* **line 547**: opal cannot use mutable strings (see opal/rspec/fixes.rb)
52-
53-
* **line 564**: opal cannot use mutable strings (see opal/rspec/fixes.rb). Also, opal
54-
does not support 2 regexp special characters yet (`\A` and `\z`).
55-
56-
### rspec/matchers/built_in/have.rb
57-
58-
* **line 1**: this is an error in rspec. This autoload does not exist so we must
59-
stub the file.
60-
6149
## License
6250

6351
(The MIT License)

Rakefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ def build_rspec
3131
Opal::Processor.stub_file asset
3232
end
3333

34+
# bug in rspec? this autoload doesnt exist so we must stub it
35+
Opal::Processor.stub_file 'rspec/matchers/built_in/have'
36+
3437
Opal.process('rspec-builder')
3538
end
3639

app/rspec/matchers/built_in/have.rb

Whitespace-only changes.

opal/opal/rspec/fixes.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ def prefix_and_expected(symbol)
3131
end
3232

3333
module RSpec::ExampleGroups
34+
# opal cannot use mutable strings AND opal doesnt support `\A` or `\z` anchors
3435
def self.base_name_for(group)
3536
return "Anonymous" if group.description.empty?
3637

@@ -48,6 +49,7 @@ def self.base_name_for(group)
4849
name
4950
end
5051

52+
# opal cannot use mutable strings
5153
def self.disambiguate(name, const_scope)
5254
return name unless const_scope.const_defined?(name)
5355

0 commit comments

Comments
 (0)