Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get working with arity checking enabled #40

Closed
wied03 opened this issue Oct 22, 2015 · 2 comments
Closed

Get working with arity checking enabled #40

wied03 opened this issue Oct 22, 2015 · 2 comments
Assignees
Milestone

Comments

@wied03
Copy link
Contributor

@wied03 wied03 commented Oct 22, 2015

  1. Code Changes
    • private_class_method needs to support multiple args - opal/opal#1168
    • All Promise::value calls without arguments need to be replaced
    • The module_exec method declaration needs to accept arguments besides a block (in Opal master the other arguments are passed on via JS arguments, but it's not in the method declaration, so the arity check fails - opal/opal#1169
    • Support fuzzy matcher filter (exclude passing)
  2. Rake Tasks:
    • other_specs
    • opal_specs
    • rspec-core - 14 unexpected failures
    • rspec-support
    • rspec-expectations
    • rspec-mocks
    • complete CI run
    • Document
@wied03 wied03 self-assigned this Oct 22, 2015
@wied03 wied03 changed the title Get working with arity checking enabled Get working with arity checking enabled on Opal 0.9 Oct 28, 2015
@wied03
Copy link
Contributor Author

@wied03 wied03 commented Dec 9, 2015

Number of unexpected fails on rspec-core went up due to opal/opal#1237

@wied03 wied03 added this to the 0.6 Release milestone Jan 22, 2016
@wied03 wied03 changed the title Get working with arity checking enabled on Opal 0.9 Get working with arity checking enabled Jan 22, 2016
@wied03
Copy link
Contributor Author

@wied03 wied03 commented Feb 29, 2016

Merging this effort into #53

@wied03 wied03 closed this Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.