Skip to content

Commit 373eafd

Browse files
committed
Group failing recursive array specs together
1 parent 37b8b54 commit 373eafd

File tree

1 file changed

+15
-16
lines changed

1 file changed

+15
-16
lines changed

spec/opal/filters/bugs/array.rb

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
fails "Array#<=> calls <=> left to right and return first non-0 result"
1515
fails "Array#<=> returns -1 if the arrays have same length and a pair of corresponding elements returns -1 for <=>"
1616
fails "Array#<=> returns +1 if the arrays have same length and a pair of corresponding elements returns +1 for <=>"
17-
fails "Array#<=> properly handles recursive arrays"
1817
fails "Array#<=> tries to convert the passed argument to an Array using #to_ary"
1918
fails "Array#<=> returns nil when the argument is not array-like"
2019

@@ -25,19 +24,13 @@
2524

2625
fails "Array#[]= sets elements in the range arguments when passed ranges"
2726

28-
fails "Array#eql? handles well recursive arrays"
29-
30-
fails "Array#== handles well recursive arrays"
31-
3227
fails "Array#flatten does not call flatten on elements"
33-
fails "Array#flatten raises an ArgumentError on recursive arrays"
3428
fails "Array#flatten with a non-Array object in the Array ignores the return value of #to_ary if it is nil"
3529
fails "Array#flatten with a non-Array object in the Array raises a TypeError if the return value of #to_ary is not an Array"
3630
fails "Array#flatten raises a TypeError when the passed Object can't be converted to an Integer"
3731
fails "Array#flatten tries to convert passed Objects to Integers using #to_int"
3832

3933
fails "Array#flatten! does not call flatten! on elements"
40-
fails "Array#flatten! raises an ArgumentError on recursive arrays"
4134
fails "Array#flatten! flattens any elements which responds to #to_ary, using the return value of said method"
4235
fails "Array#flatten! raises a TypeError when the passed Object can't be converted to an Integer"
4336
fails "Array#flatten! tries to convert passed Objects to Integers using #to_int"
@@ -55,9 +48,6 @@
5548
fails "Array#initialize with (array) calls #to_ary to convert the value to an array"
5649
fails "Array#initialize preserves the object's identity even when changing its value"
5750

58-
fails "Array#join raises an ArgumentError when the Array is recursive"
59-
60-
fails "Array#& properly handles recursive arrays"
6151
fails "Array#& tries to convert the passed argument to an Array using #to_ary"
6252
fails "Array#& determines equivalence between elements in the sense of eql?"
6353

@@ -188,12 +178,10 @@
188178
fails "Array#uniq uses eql? semantics"
189179

190180
fails "Array#uniq! compares elements based on the value returned from the block"
191-
fails "Array#uniq! properly handles recursive arrays"
192181

193182
fails "Array#values_at returns an array of elements at the indexes when passed indexes"
194183
fails "Array#values_at calls to_int on its indices"
195184
fails "Array#values_at returns an array of elements in the ranges when passes ranges"
196-
fails "Array#values_at properly handles recursive arrays"
197185
fails "Array#values_at calls to_int on arguments of ranges when passes ranges"
198186
fails "Array#values_at does not return subclass instance on Array subclasses"
199187

@@ -204,11 +192,8 @@
204192
fails "Array#hash returns same hash code for arrays with the same content"
205193
fails "Array#hash ignores array class differences"
206194
fails "Array#hash calls to_int on result of calling hash on each element"
207-
fails "Array#hash returns the same hash for equal recursive arrays through hashes"
208-
fails "Array#hash returns the same hash for equal recursive arrays"
209195
fails "Array#hash returns the same fixnum for arrays with the same content"
210196

211-
fails "Array#partition properly handles recursive arrays"
212197
fails "Array#partition returns in the left array values for which the block evaluates to true"
213198
fails "Array#partition returns two arrays"
214199
fails "Array#partition does not return subclass instances on Array subclasses"
@@ -217,8 +202,22 @@
217202
fails "Array#| does not return subclass instances for Array subclasses"
218203
fails "Array#| acts as if using an intermediate hash to collect values"
219204
fails "Array#| tries to convert the passed argument to an Array using #to_ary"
220-
fails "Array#| properly handles recursive arrays"
221205
fails "Array#| creates an array with elements in order they are first encountered"
222206
fails "Array#| creates an array with no duplicates"
223207
fails "Array#| returns an array of elements that appear in either array (union)"
208+
209+
# recursive arrays
210+
fails "Array#join raises an ArgumentError when the Array is recursive"
211+
fails "Array#uniq! properly handles recursive arrays"
212+
fails "Array#| properly handles recursive arrays"
213+
fails "Array#<=> properly handles recursive arrays"
214+
fails "Array#eql? handles well recursive arrays"
215+
fails "Array#== handles well recursive arrays"
216+
fails "Array#flatten raises an ArgumentError on recursive arrays"
217+
fails "Array#flatten! raises an ArgumentError on recursive arrays"
218+
fails "Array#partition properly handles recursive arrays"
219+
fails "Array#& properly handles recursive arrays"
220+
fails "Array#values_at properly handles recursive arrays"
221+
fails "Array#hash returns the same hash for equal recursive arrays through hashes"
222+
fails "Array#hash returns the same hash for equal recursive arrays"
224223
end

0 commit comments

Comments
 (0)