Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squiggly here doc breaks try opal in browser #2169

Closed
rubys opened this issue Jan 19, 2021 · 0 comments · Fixed by #2364
Closed

squiggly here doc breaks try opal in browser #2169

rubys opened this issue Jan 19, 2021 · 0 comments · Fixed by #2364
Labels
v1.2 Still an issue on v1.2

Comments

@rubys
Copy link
Contributor

rubys commented Jan 19, 2021

Reproduction instructions. Go to https://opalrb.com/try/#

Enter the following in the text area:

x = <<~HERE
  xxx
HERE

Press the Run button.

Note also that there is an unhandled exception in the console log.

The patches needed to fix this can be found at https://github.com/ruby2js/ruby2js/blob/f05434dba39e53f1314a57ad82f18ca8786aa866/demo/patch.opal#L43

In that same file, you can find patches needed to get diagnostics working, and to update stdlib Racc to 1.8.5.

FYI, the above patches are deployed at https://ruby2js.com/demo

@hmdne hmdne added the v1.2 Still an issue on v1.2 label Aug 20, 2021
hmdne added a commit that referenced this issue Nov 24, 2021
hmdne added a commit that referenced this issue Nov 24, 2021
hmdne added a commit that referenced this issue Nov 24, 2021
hmdne added a commit that referenced this issue Dec 8, 2021
hmdne added a commit that referenced this issue Dec 19, 2021
* Fixes #2169
* Fixes #2363

Co-authored-by: Sam Ruby <rubys@intertwingly.net>
hmdne added a commit that referenced this issue Dec 19, 2021
* Fixes #2169
* Fixes #2363

Co-authored-by: Sam Ruby <rubys@intertwingly.net>
hmdne added a commit that referenced this issue Dec 19, 2021
* Fixes #2169
* Fixes #2363

Co-authored-by: Sam Ruby <rubys@intertwingly.net>
elia pushed a commit that referenced this issue Dec 19, 2021
* Fixes #2169
* Fixes #2363

Avoid using String#slice! in the dedenter and expect a new string for
replacement in #dedent_string. Most of the other changes are dictated
by Rubocop.
elia pushed a commit that referenced this issue Dec 19, 2021
* Fixes #2169
* Fixes #2363

Avoid using String#slice! in the dedenter and expect a new string for
replacement in #dedent_string. Most of the other changes are dictated
by Rubocop.
hmdne added a commit that referenced this issue Dec 20, 2021
* Fixes #2169
* Fixes #2363

Avoid using String#slice! in the dedenter and expect a new string for
replacement in #dedent_string. Most of the other changes are dictated
by Rubocop.

Co-authored-by: Elia Schito <elia@schito.me>
hmdne added a commit that referenced this issue Dec 20, 2021
* Fixes #2169
* Fixes #2363

Avoid using String#slice! in the dedenter and expect a new string for
replacement in #dedent_string. Most of the other changes are dictated
by Rubocop.

Co-authored-by: Elia Schito <elia@schito.me>
Co-authored-by: Sam Ruby <rubys@intertwingly.net>
hmdne added a commit that referenced this issue Dec 20, 2021
* Fixes #2169
* Fixes #2363

Avoid using String#slice! in the dedenter and expect a new string for
replacement in #dedent_string. Most of the other changes are dictated
by Rubocop.

Co-authored-by: Elia Schito <elia@schito.me>
Co-authored-by: Sam Ruby <rubys@intertwingly.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.2 Still an issue on v1.2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants